Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: content/renderer/presentation/presentation_connection_client.cc

Issue 2327993002: [PresentationAPI] Use KURL and WebURL in place of string types. (Closed)
Patch Set: Rebase. Fix PresentationReceiverTest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/presentation/presentation_connection_client.cc
diff --git a/content/renderer/presentation/presentation_connection_client.cc b/content/renderer/presentation/presentation_connection_client.cc
index 17e6226944bc1aece4f4ae53ae9f6c2a472f09b8..0118334f9bb66e28605ebb7482596108f5638b3a 100644
--- a/content/renderer/presentation/presentation_connection_client.cc
+++ b/content/renderer/presentation/presentation_connection_client.cc
@@ -6,24 +6,25 @@
#include "base/logging.h"
#include "third_party/WebKit/public/platform/WebString.h"
+#include "third_party/WebKit/public/platform/WebURL.h"
namespace content {
PresentationConnectionClient::PresentationConnectionClient(
blink::mojom::PresentationSessionInfoPtr session_info)
- : url_(blink::WebString::fromUTF8(session_info->url.spec())),
+ : url_(blink::WebURL(session_info->url)),
imcheng 2016/09/14 00:39:13 nit: can this url_(session_info->url) ?
mark a. foltz 2016/09/14 20:02:42 Done.
id_(blink::WebString::fromUTF8(session_info->id)) {}
PresentationConnectionClient::PresentationConnectionClient(
const GURL& url,
const mojo::String& id)
- : url_(blink::WebString::fromUTF8(url.spec())),
+ : url_(blink::WebURL(url)),
imcheng 2016/09/14 00:39:13 ditto
mark a. foltz 2016/09/14 20:02:41 Done.
id_(blink::WebString::fromUTF8(id)) {}
PresentationConnectionClient::~PresentationConnectionClient() {
}
-blink::WebString PresentationConnectionClient::getUrl() {
+blink::WebURL PresentationConnectionClient::getUrl() {
return url_;
}

Powered by Google App Engine
This is Rietveld 408576698