Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2327983002: [DevTools] Migrate StylesSidebarPane to TreeOutlineInShadow. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate StylesSidebarPane to TreeOutlineInShadow. This is a step towards turning all tree outlines into independent web components, removing global styles related to it and allowing more components to encapsulate their inner details. BUG=none Committed: https://crrev.com/5b494767ab26e78c514244b4cf3d1e8fda2c7e77 Cr-Commit-Position: refs/heads/master@{#419836}

Patch Set 1 #

Patch Set 2 : fixed box shadow #

Patch Set 3 : rebased, deep selection check #

Patch Set 4 : filtering, tests #

Messages

Total messages: 18 (7 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-09 23:48:34 UTC) #2
lushnikov
I applied it and it mostly works; the only issue I've found is the new ...
4 years, 3 months ago (2016-09-10 01:06:03 UTC) #3
dgozman
On 2016/09/10 01:06:03, lushnikov wrote: > I applied it and it mostly works; the only ...
4 years, 3 months ago (2016-09-14 16:40:53 UTC) #4
dgozman
Fixed the problem, PTAL.
4 years, 3 months ago (2016-09-14 22:04:29 UTC) #5
lushnikov
applied it locally; giving it a try
4 years, 3 months ago (2016-09-15 17:47:37 UTC) #6
lushnikov
lgtm
4 years, 3 months ago (2016-09-19 18:15:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327983002/40001
4 years, 3 months ago (2016-09-19 20:13:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/295667)
4 years, 3 months ago (2016-09-19 21:39:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327983002/60001
4 years, 3 months ago (2016-09-20 17:30:39 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-20 19:12:30 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:14:27 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5b494767ab26e78c514244b4cf3d1e8fda2c7e77
Cr-Commit-Position: refs/heads/master@{#419836}

Powered by Google App Engine
This is Rietveld 408576698