Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: net/cert/x509_util.cc

Issue 2327973002: Add CertErrors* parameter to the main Certificate parsing functions. (Closed)
Patch Set: fix comment typeo Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/x509_util.cc
diff --git a/net/cert/x509_util.cc b/net/cert/x509_util.cc
index 8729e560c64aecefb4befcdf59389a99429e5b6d..4cb7bb05edf0b75ff5c5f17c53417738d5180875 100644
--- a/net/cert/x509_util.cc
+++ b/net/cert/x509_util.cc
@@ -10,6 +10,7 @@
#include "crypto/ec_private_key.h"
#include "crypto/rsa_private_key.h"
#include "net/base/hash_value.h"
+#include "net/cert/internal/cert_errors.h"
#include "net/cert/internal/name_constraints.h"
#include "net/cert/internal/parse_certificate.h"
#include "net/cert/internal/parse_name.h"
@@ -127,7 +128,9 @@ bool ParseCertificateSandboxed(const base::StringPiece& certificate,
der::Input cert_data(certificate);
der::Input tbs_cert, signature_alg;
der::BitString signature_value;
- if (!ParseCertificate(cert_data, &tbs_cert, &signature_alg, &signature_value))
+ CertErrors errors;
+ if (!ParseCertificate(cert_data, &tbs_cert, &signature_alg, &signature_value,
+ &errors))
mattm 2016/09/12 23:29:27 should this be nullptr, or should there be a TODO
eroman 2016/09/12 23:42:59 Done, changed to nullptr.
return false;
ParsedTbsCertificate parsed_tbs_cert;

Powered by Google App Engine
This is Rietveld 408576698