Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: net/cert/internal/path_builder_pkits_unittest.cc

Issue 2327973002: Add CertErrors* parameter to the main Certificate parsing functions. (Closed)
Patch Set: StringPiece is kind of dangerous... Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/parsed_certificate.cc ('k') | net/cert/internal/path_builder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/path_builder_pkits_unittest.cc
diff --git a/net/cert/internal/path_builder_pkits_unittest.cc b/net/cert/internal/path_builder_pkits_unittest.cc
index 26bd043c5f0fb5a3b9f34259e2ba6468b52e6239..4039428687e80f4e954374ddd7d76964a62a95d3 100644
--- a/net/cert/internal/path_builder_pkits_unittest.cc
+++ b/net/cert/internal/path_builder_pkits_unittest.cc
@@ -58,9 +58,10 @@ class PathBuilderPkitsTestDelegate {
}
ParsedCertificateList certs;
for (const std::string& der : cert_ders) {
- certs.push_back(ParsedCertificate::CreateFromCertificateCopy(der, {}));
- if (!certs.back()) {
- ADD_FAILURE() << "ParsedCertificate::CreateFromCertificateCopy failed";
+ CertErrors errors;
+ if (!ParsedCertificate::CreateAndAddToVector(der, {}, &certs, &errors)) {
+ ADD_FAILURE() << "ParseCertificate::CreateAndAddToVector() failed:\n"
+ << errors.ToDebugString();
return false;
}
}
« no previous file with comments | « net/cert/internal/parsed_certificate.cc ('k') | net/cert/internal/path_builder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698