Add CertErrors* parameter to the main Certificate parsing functions.

net/cert/internal/trust_store_nss.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/trust_store_nss.h"
 
 #include <cert.h>
 #include <certdb.h>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/weak_ptr.h"
 #include "base/task_runner.h"
 #include "crypto/nss_util.h"
+#include "net/cert/internal/cert_errors.h"
 #include "net/cert/internal/parsed_certificate.h"
 
 // TODO(mattm): structure so that supporting ChromeOS multi-profile stuff is
 // doable (Have a TrustStoreChromeOS which uses net::NSSProfileFilterChromeOS,
 // similar to CertVerifyProcChromeOS.)
 
 namespace net {
 
 namespace {
 
@@ skipping 23 matching lines @@
        !CERT_LIST_END(node, found_certs); node = CERT_LIST_NEXT(node)) {
     CERTCertTrust trust;
     if (CERT_GetCertTrust(node->cert, &trust) != SECSuccess)
       continue;
 
     // TODO(mattm): handle explicit distrust (blacklisting)?
     const int ca_trust = CERTDB_TRUSTED_CA;
     if ((SEC_GET_TRUST_FLAGS(&trust, trust_type) & ca_trust) != ca_trust)
       continue;
 
-    scoped_refptr<ParsedCertificate> anchor_cert =
-        ParsedCertificate::CreateFromCertificateData(
-            node->cert->derCert.data, node->cert->derCert.len,
-            ParsedCertificate::DataSource::INTERNAL_COPY, {});
+    CertErrors errors;
+    scoped_refptr<ParsedCertificate> anchor_cert = ParsedCertificate::Create(
+        node->cert->derCert.data, node->cert->derCert.len, {}, &errors);
     if (!anchor_cert) {
-      // TODO(mattm): return errors better.
-      LOG(ERROR) << "error parsing issuer certificate";
+      // TODO(crbug.com/634443): return errors better.
+      LOG(ERROR) << "Error parsing issuer certificate:\n"
+                 << errors.ToDebugString();
       continue;
     }
 
     out_anchors->push_back(TrustAnchor::CreateFromCertificateNoConstraints(
         std::move(anchor_cert)));
   }
   CERT_DestroyCertList(found_certs);
 }
 
 class GetAnchorsRequest : public TrustStore::Request {
@@ skipping 51 matching lines @@
     std::unique_ptr<Request>* out_req) const {
   if (callback.is_null())
     return;
 
   auto req = base::MakeUnique<GetAnchorsRequest>(callback);
   req->Start(cert, trust_type_, nss_task_runner_.get());
   *out_req = std::move(req);
 }
 
 }  // namespace net