Add CertErrors* parameter to the main Certificate parsing functions.

net/cert/internal/cert_issuer_source_aia.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/cert_issuer_source_aia.h"
 
 #include "base/bind.h"
 #include "net/cert/cert_net_fetcher.h"
+#include "net/cert/internal/cert_errors.h"
 #include "url/gurl.h"
 
 namespace net {
 
 namespace {
 
 // TODO(mattm): These are arbitrary choices. Re-evaluate.
 const int kTimeoutMilliseconds = 10000;
 const int kMaxResponseBytes = 65536;
 const int kMaxFetchesPerCert = 5;
@@ skipping 60 matching lines @@
     //
     //    Conforming applications that support HTTP or FTP for accessing
     //    certificates MUST be able to accept individual DER encoded
     //    certificates and SHOULD be able to accept "certs-only" CMS messages.
     //
     // TODO(mattm): Is supporting CMS message format important?
     //
     // TODO(mattm): Avoid copying bytes. Change the CertNetFetcher and
     // ParsedCertificate interface to allow passing through ownership of the
     // bytes.
-    if (!ParsedCertificate::CreateAndAddToVector(
-            fetched_bytes.data(), fetched_bytes.size(),
-            ParsedCertificate::DataSource::INTERNAL_COPY, {}, &results_)) {
-      // TODO(mattm): propagate error info.
-      LOG(ERROR) << "Error parsing AIA data";
+    CertErrors errors;
+    if (!ParsedCertificate::CreateAndAddToVector(fetched_bytes.data(),
+                                                 fetched_bytes.size(), {},
+                                                 &results_, &errors)) {
+      // TODO(crbug.com/634443): propagate error info.
+      LOG(ERROR) << "Error parsing cert retrieved from AIA:\n"
+                 << errors.ToDebugString();
     }
   }
   // If the client is waiting for results, need to run callback if:
   //  * Some are available now.
   //  * The last fetch finished, even with no results. (Client needs to know to
   //    stop waiting.)
   if (client_waiting_for_callback && (HasNext() || pending_requests_ == 0))
     issuers_callback_.Run(this);
 }
 
@@ skipping 54 matching lines @@
     aia_request->AddCertFetcherRequest(cert_fetcher_->FetchCaIssuers(
         url, kTimeoutMilliseconds, kMaxResponseBytes,
         base::Bind(&AiaRequest::OnFetchCompleted,
                    base::Unretained(aia_request.get()))));
   }
 
   *out_req = std::move(aia_request);
 }
 
 }  // namespace net