SkPDF: refactor & code cleanup ahead of https://crrev.com/2322403002

src/pdf/SkPDFResourceDict.cpp

Index: src/pdf/SkPDFResourceDict.cpp
diff --git a/src/pdf/SkPDFResourceDict.cpp b/src/pdf/SkPDFResourceDict.cpp
index b24f8a5877b23f78faf86df791d2c4ef44aec4a9..67e81b6c7b5912f461a00fd1997465c46bd83a24 100644
--- a/src/pdf/SkPDFResourceDict.cpp
+++ b/src/pdf/SkPDFResourceDict.cpp
@@ -32,7 +32,7 @@ static const char* resource_type_names[] = {
         "Font"
 };
 
-static char get_resource_type_prefix(
+char SkPDFResourceDict::GetResourceTypePrefix(
         SkPDFResourceDict::SkPDFResourceType type) {
     SkASSERT(type >= 0);
     SkASSERT(type < SkPDFResourceDict::kResourceTypeCount);
@@ -50,9 +50,7 @@ static const char* get_resource_type_name(
 
 SkString SkPDFResourceDict::getResourceName(
         SkPDFResourceDict::SkPDFResourceType type, int key) {
-    SkString keyString;
-    keyString.printf("%c%d", get_resource_type_prefix(type), key);
-    return keyString;
+    return SkStringPrintf("%c%d", SkPDFResourceDict::GetResourceTypePrefix(type), key);

[tomhudson, 2016/09/12 14:49:09]

Why was making the function part of the API necessary for this temp-elimination?

[hal.canary, 2016/09/12 14:59:23]

This function is functionally unchanged, and I still use it somewhere else.  It
was written before SkStringPrintf() existed, so I cleaned that up.

 }
 
 static void add_subdict(