gfx: Do the ToEnclosingRect in double precision.

gfx: Do the ToEnclosingRect in double precision.

This patch changes ToEnclosingRect to use doubles instead of float
when computing width/height, since lack of precision in floats can
cause incorrect values (as shown in the test).

R=danakj
BUG=644873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/50000257dcf62a1c146c03617c7f1100800faf28
Cr-Commit-Position: refs/heads/master@{#417772}

[vmpstr, 2016-09-09 19:59:07]

Please take a look.

[danakj, 2016-09-09 20:16:46]

Seems good, can you do a telemetry try run for thread times to verify its
nothing crazy?

[vmpstr, 2016-09-09 21:34:41]

On 2016/09/09 20:16:46, danakj wrote:
> Seems good, can you do a telemetry try run for thread times to verify its
> nothing crazy?

thread_times.simple_mobile_sites has the same results before and after the
patch.

[danakj, 2016-09-09 21:44:33]

On 2016/09/09 21:34:41, vmpstr wrote:
> On 2016/09/09 20:16:46, danakj wrote:
> > Seems good, can you do a telemetry try run for thread times to verify its
> > nothing crazy?
> 
> thread_times.simple_mobile_sites has the same results before and after the
> patch.

Thanks, LGTM

[vmpstr, 2016-09-09 21:44:49]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-09-09 21:45:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 22:24:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 22:24:39]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vmpstr, 2016-09-09 22:56:35]

Description was changed from

==========
gfx: Do the ToEnclosingRect in double precision.

This patch changes ToEnclosingRect to use doubles instead of float
when computing width/height, since lack of precision in floats can
cause incorrect values (as shown in the test).

R=danakj
BUG=644873
==========

to

==========
gfx: Do the ToEnclosingRect in double precision.

This patch changes ToEnclosingRect to use doubles instead of float
when computing width/height, since lack of precision in floats can
cause incorrect values (as shown in the test).

R=danakj
BUG=644873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[vmpstr, 2016-09-09 22:56:38]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 22:57:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-09 23:08:09]

LGTM

[vmpstr, 2016-09-09 23:08:36]

The CQ bit was unchecked by vmpstr@chromium.org

[vmpstr, 2016-09-09 23:08:37]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-09-09 23:08:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 00:07:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-10 00:09:21]

Description was changed from

==========
gfx: Do the ToEnclosingRect in double precision.

This patch changes ToEnclosingRect to use doubles instead of float
when computing width/height, since lack of precision in floats can
cause incorrect values (as shown in the test).

R=danakj
BUG=644873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
gfx: Do the ToEnclosingRect in double precision.

This patch changes ToEnclosingRect to use doubles instead of float
when computing width/height, since lack of precision in floats can
cause incorrect values (as shown in the test).

R=danakj
BUG=644873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/50000257dcf62a1c146c03617c7f1100800faf28
Cr-Commit-Position: refs/heads/master@{#417772}
==========

[commit-bot: I haz the power, 2016-09-10 00:09:22]

Patchset 2 (id:??) landed as
https://crrev.com/50000257dcf62a1c146c03617c7f1100800faf28
Cr-Commit-Position: refs/heads/master@{#417772}