Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 23279010: Introduce toSVGAnimateElement(), and use it (Closed)

Created:
7 years, 4 months ago by gyuyoung-inactive
Modified:
7 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toSVGAnimateElement(), and use it As a step to clean-up static_cast<SVGXXX>, static_cast<SVGAnimateElement*> also can be changed with toSVGAnimateElement(). BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156284

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M Source/core/svg/SVGAnimateElement.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gyuyoung-inactive
Add Kent Tamura as reviewer.
7 years, 4 months ago (2013-08-18 15:26:13 UTC) #1
tkent
> Additionally this cl adds a toStopElement(Node* node) in order to remove a > 'static_cast<SVGStopElement*>' ...
7 years, 4 months ago (2013-08-18 22:16:48 UTC) #2
tkent
https://codereview.chromium.org/23279010/diff/1/Source/core/svg/SVGAnimateElement.h File Source/core/svg/SVGAnimateElement.h (right): https://codereview.chromium.org/23279010/diff/1/Source/core/svg/SVGAnimateElement.h#newcode79 Source/core/svg/SVGAnimateElement.h:79: ASSERT_WITH_SECURITY_IMPLICATION(!element || element->hasTagName(SVGNames::animateTag)); This is wrong. We can cast ...
7 years, 4 months ago (2013-08-18 22:18:44 UTC) #3
gyuyoung-inactive
On 2013/08/18 22:18:44, tkent wrote: > https://codereview.chromium.org/23279010/diff/1/Source/core/svg/SVGAnimateElement.h > File Source/core/svg/SVGAnimateElement.h (right): > > https://codereview.chromium.org/23279010/diff/1/Source/core/svg/SVGAnimateElement.h#newcode79 > ...
7 years, 4 months ago (2013-08-18 23:49:54 UTC) #4
gyuyoung-inactive
On 2013/08/18 22:16:48, tkent wrote: > > Additionally this cl adds a toStopElement(Node* node) in ...
7 years, 4 months ago (2013-08-18 23:50:27 UTC) #5
tkent
lgtm
7 years, 4 months ago (2013-08-18 23:57:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23279010/5001
7 years, 4 months ago (2013-08-18 23:57:40 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=2483
7 years, 4 months ago (2013-08-19 03:41:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23279010/5001
7 years, 4 months ago (2013-08-19 03:45:30 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 04:45:56 UTC) #10
Message was sent while issue was closed.
Change committed as 156284

Powered by Google App Engine
This is Rietveld 408576698