Issue 23279007: Initialize the 'policy' setting of all cipher suites to SSL_ALLOWED,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23279007: Initialize the 'policy' setting of all cipher suites to SSL_ALLOWED, (Closed)

Created:
7 years, 4 months ago by wtc

Modified:
7 years, 4 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[FOR CODE REVIEW ONLY.] Initialize the 'policy' setting of all cipher suites to SSL_ALLOWED, so that NSS_SetDomesticPolicy doesn't need to be called. Remove the local ssl_ciphers array in sslsock.c and have NSS_SetDomesticPolicy use the SSL_ImplementedCiphers array instead. Upstream NSS bug: https://bugzilla.mozilla.org/show_bug.cgi?id=848384 R=rsleevi@chromium.org BUG=none TEST=one

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -164 lines)			Patch
M	net/third_party/nss/ssl/ssl.h	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl3con.c	View	3 chunks	+64 lines, -65 lines	0 comments	Download
M	net/third_party/nss/ssl/sslcon.c	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/third_party/nss/ssl/sslimpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/third_party/nss/ssl/sslsock.c	View	2 chunks	+3 lines, -89 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

wtc

7 years, 4 months ago (2013-08-17 00:53:39 UTC) #1

I won't commit this CL in the Chromium tree. I just wanted
to let you use Rietveld to review an upstream NSS patch.
Thanks.

Expand Messages | Collapse Messages