Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2327833002: Address HandlerLeak lint warnings. (Closed)
Patch Set: Remove suppressions. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index f97f467908e0ad2af404f8aed63c22a52cd2777b..f251e467833349e6e079110b2bce0d25253faf22 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -50,6 +50,7 @@ import org.chromium.chrome.browser.NativePage;
import org.chromium.chrome.browser.SwipeRefreshHandler;
import org.chromium.chrome.browser.TabState;
import org.chromium.chrome.browser.TabState.WebContentsState;
+import org.chromium.chrome.browser.TidyHandler;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.WarmupManager;
import org.chromium.chrome.browser.WebContentsFactory;
@@ -597,6 +598,21 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
private TopControlsVisibilityDelegate mTopControlsVisibilityDelegate;
+ private static class TabEventHandler extends TidyHandler<Tab> {
+
+ public TabEventHandler(Tab instance) {
+ super(instance);
+ }
+
+ @Override
+ public void handleMessage(Message msg, Tab instance) {
+ if (msg == null) return;
+ if (msg.what == MSG_ID_ENABLE_FULLSCREEN_AFTER_LOAD) {
+ instance.enableFullscreenAfterLoad();
+ }
+ }
+ }
+
/**
* Creates an instance of a {@link Tab}.
*
@@ -657,15 +673,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
setContentViewClient(new TabContentViewClient());
- mHandler = new Handler() {
- @Override
- public void handleMessage(Message msg) {
- if (msg == null) return;
- if (msg.what == MSG_ID_ENABLE_FULLSCREEN_AFTER_LOAD) {
- enableFullscreenAfterLoad();
- }
- }
- };
+ mHandler = new TabEventHandler(this);
mTabRedirectHandler = new TabRedirectHandler(mThemedApplicationContext);
addObserver(mTabObserver);

Powered by Google App Engine
This is Rietveld 408576698