Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2327833002: Address HandlerLeak lint warnings. (Closed)
Patch Set: Remove suppressions. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/TidyHandler.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/TidyHandler.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /PopupZoomer.java" /> 52 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /PopupZoomer.java" />
53 </issue> 53 </issue>
54 <issue id="ExportedContentProvider"> 54 <issue id="ExportedContentProvider">
55 <ignore path="AndroidManifest.xml" /> 55 <ignore path="AndroidManifest.xml" />
56 </issue> 56 </issue>
57 <issue id="ExportedService" severity="Error"> 57 <issue id="ExportedService" severity="Error">
58 <ignore regexp="AndroidManifest.xml" /> 58 <ignore regexp="AndroidManifest.xml" />
59 </issue> 59 </issue>
60 <issue id="HandlerLeak"> 60 <issue id="HandlerLeak">
61 <ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/W ebViewContentsClientAdapter.java" /> 61 <ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/W ebViewContentsClientAdapter.java" />
62 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/composit or/overlays/strip/StripLayoutHelper.java" />
63 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAS erviceClient.java" />
64 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/tab/Tab. java" />
65 <ignore regexp="chromecast/internal" /> 62 <ignore regexp="chromecast/internal" />
66 <ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGesture Detector.java" /> 63 <ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGesture Detector.java" />
67 </issue> 64 </issue>
68 <issue id="HardcodedDebugMode" severity="Fatal"> 65 <issue id="HardcodedDebugMode" severity="Fatal">
69 <ignore path="AndroidManifest.xml" /> 66 <ignore path="AndroidManifest.xml" />
70 </issue> 67 </issue>
71 <issue id="HardcodedText" severity="Error"> 68 <issue id="HardcodedText" severity="Error">
72 <ignore regexp="chromecast/internal" /> 69 <ignore regexp="chromecast/internal" />
73 <ignore regexp="remoting/android/host/res/layout/main.xml" /> 70 <ignore regexp="remoting/android/host/res/layout/main.xml" />
74 </issue> 71 </issue>
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 </issue> 296 </issue>
300 <issue id="ViewConstructor" severity="ignore" /> 297 <issue id="ViewConstructor" severity="ignore" />
301 <issue id="WrongCall" severity="ignore" /> 298 <issue id="WrongCall" severity="ignore" />
302 <issue id="WrongConstant"> 299 <issue id="WrongConstant">
303 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java" /> 300 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java" />
304 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java" /> 301 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java" />
305 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java" /> 302 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java" />
306 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java" /> 303 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java" />
307 </issue> 304 </issue>
308 </lint> 305 </lint>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/TidyHandler.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/TidyHandler.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698