Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: ui/ozone/platform/drm/gpu/gbm_surface_factory.cc

Issue 2327813002: Convert Ozone GBM to use GLOzone. (Closed)
Patch Set: Typo. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/ozone/platform/drm/gpu/gbm_surface_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
diff --git a/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc b/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
index 6b6340a0c16394e63b5e6c0fff4e06129de6e1c9..742733b1959e20d6d6fa17ca68d7bd4adfc2829e 100644
--- a/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
+++ b/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
@@ -15,6 +15,7 @@
#include "ui/gfx/buffer_format_util.h"
#include "ui/gl/gl_surface_egl.h"
#include "ui/ozone/common/egl_util.h"
+#include "ui/ozone/common/gl_ozone_egl.h"
#include "ui/ozone/platform/drm/common/drm_util.h"
#include "ui/ozone/platform/drm/gpu/drm_thread_proxy.h"
#include "ui/ozone/platform/drm/gpu/drm_window_proxy.h"
@@ -28,8 +29,50 @@
namespace ui {
+namespace {
+
+class GLOzoneEGLGbm : public GLOzoneEGL {
+ public:
+ GLOzoneEGLGbm(GbmSurfaceFactory* surface_factory, DrmThreadProxy* drm_thread)
+ : surface_factory_(surface_factory), drm_thread_(drm_thread) {}
+ ~GLOzoneEGLGbm() override {}
+
+ scoped_refptr<gl::GLSurface> CreateViewGLSurface(
+ gfx::AcceleratedWidget window) override {
+ return gl::InitializeGLSurface(new GbmSurface(
+ surface_factory_, drm_thread_->CreateDrmWindowProxy(window), window));
+ }
+
+ scoped_refptr<gl::GLSurface> CreateSurfacelessViewGLSurface(
+ gfx::AcceleratedWidget window) override {
+ return gl::InitializeGLSurface(new GbmSurfaceless(
+ surface_factory_, drm_thread_->CreateDrmWindowProxy(window), window));
+ }
+
+ scoped_refptr<gl::GLSurface> CreateOffscreenGLSurface(
+ const gfx::Size& size) override {
+ DCHECK_EQ(size.width(), 0);
+ DCHECK_EQ(size.height(), 0);
+ return gl::InitializeGLSurface(new gl::SurfacelessEGL(size));
+ }
+
+ protected:
+ intptr_t GetNativeDisplay() override { return EGL_DEFAULT_DISPLAY; }
+
+ bool LoadGLES2Bindings() override { return LoadDefaultEGLGLES2Bindings(); }
+
+ private:
+ GbmSurfaceFactory* surface_factory_;
+ DrmThreadProxy* drm_thread_;
+
+ DISALLOW_COPY_AND_ASSIGN(GLOzoneEGLGbm);
+};
+
+} // namespace
+
GbmSurfaceFactory::GbmSurfaceFactory(DrmThreadProxy* drm_thread)
- : drm_thread_(drm_thread) {}
+ : egl_implementation_(new GLOzoneEGLGbm(this, drm_thread)),
+ drm_thread_(drm_thread) {}
GbmSurfaceFactory::~GbmSurfaceFactory() {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -54,58 +97,23 @@ GbmSurfaceless* GbmSurfaceFactory::GetSurface(
return it->second;
}
-scoped_refptr<gl::GLSurface> GbmSurfaceFactory::CreateViewGLSurface(
- gl::GLImplementation implementation,
- gfx::AcceleratedWidget widget) {
- DCHECK(thread_checker_.CalledOnValidThread());
-
- if (implementation != gl::kGLImplementationEGLGLES2) {
- NOTREACHED();
- return nullptr;
- }
-
- return gl::InitializeGLSurface(
- new GbmSurface(this, drm_thread_->CreateDrmWindowProxy(widget), widget));
-}
-
-scoped_refptr<gl::GLSurface> GbmSurfaceFactory::CreateSurfacelessViewGLSurface(
- gl::GLImplementation implementation,
- gfx::AcceleratedWidget widget) {
+std::vector<gl::GLImplementation>
+GbmSurfaceFactory::GetAllowedGLImplementations() {
DCHECK(thread_checker_.CalledOnValidThread());
-
- if (implementation != gl::kGLImplementationEGLGLES2) {
- NOTREACHED();
- return nullptr;
- }
-
- return gl::InitializeGLSurface(new GbmSurfaceless(
- this, drm_thread_->CreateDrmWindowProxy(widget), widget));
+ std::vector<gl::GLImplementation> impls;
+ impls.push_back(gl::kGLImplementationEGLGLES2);
+ impls.push_back(gl::kGLImplementationOSMesaGL);
+ return impls;
}
-scoped_refptr<gl::GLSurface> GbmSurfaceFactory::CreateOffscreenGLSurface(
- gl::GLImplementation implementation,
- const gfx::Size& size) {
+GLOzone* GbmSurfaceFactory::GetGLOzone(gl::GLImplementation implementation) {
DCHECK(thread_checker_.CalledOnValidThread());
-
- if (implementation != gl::kGLImplementationEGLGLES2) {
- NOTREACHED();
- return nullptr;
+ switch (implementation) {
+ case gl::kGLImplementationEGLGLES2:
+ return egl_implementation_.get();
+ default:
+ return nullptr;
}
-
- DCHECK_EQ(size.width(), 0);
- DCHECK_EQ(size.height(), 0);
-
- return gl::InitializeGLSurface(new gl::SurfacelessEGL(size));
-}
-
-intptr_t GbmSurfaceFactory::GetNativeDisplay() {
- DCHECK(thread_checker_.CalledOnValidThread());
- return EGL_DEFAULT_DISPLAY;
-}
-
-bool GbmSurfaceFactory::LoadEGLGLES2Bindings() {
- DCHECK(thread_checker_.CalledOnValidThread());
- return LoadDefaultEGLGLES2Bindings();
}
std::unique_ptr<SurfaceOzoneCanvas> GbmSurfaceFactory::CreateCanvasForWidget(
« no previous file with comments | « ui/ozone/platform/drm/gpu/gbm_surface_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698