Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9315)

Unified Diff: components/dom_distiller/ios/distiller_page_ios.h

Issue 2327783002: Fix domdistiller for new JS execution (Closed)
Patch Set: comments test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/ios/distiller_page_ios.h
diff --git a/components/dom_distiller/ios/distiller_page_ios.h b/components/dom_distiller/ios/distiller_page_ios.h
index 2103959a76eebd8bedf1aad77b09aa24361126ee..1fdf87e9a91d7f70f544c2b251ac44feca9a33b0 100644
--- a/components/dom_distiller/ios/distiller_page_ios.h
+++ b/components/dom_distiller/ios/distiller_page_ios.h
@@ -44,7 +44,10 @@ class DistillerPageIOS : public DistillerPage {
void OnLoadURLDone(web::PageLoadCompletionStatus load_completion_status);
// Called once the |script_| has been evaluated on the page.
- void HandleJavaScriptResultString(NSString* result);
+ void HandleJavaScriptResult(id result);
+
+ // Converts result of WKWebView script evaluation to base::Value
+ std::unique_ptr<base::Value> ValueResultFromScriptResult(id wk_result);
web::BrowserState* browser_state_;
GURL url_;
« no previous file with comments | « no previous file | components/dom_distiller/ios/distiller_page_ios.mm » ('j') | components/dom_distiller/ios/distiller_page_ios.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698