Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: components/dom_distiller/ios/distiller_page_ios.h

Issue 2327783002: Fix domdistiller for new JS execution (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/ios/distiller_page_ios.h
diff --git a/components/dom_distiller/ios/distiller_page_ios.h b/components/dom_distiller/ios/distiller_page_ios.h
index 2103959a76eebd8bedf1aad77b09aa24361126ee..ccede5408fa5b39bcd19e56851e365538ab145cf 100644
--- a/components/dom_distiller/ios/distiller_page_ios.h
+++ b/components/dom_distiller/ios/distiller_page_ios.h
@@ -44,7 +44,9 @@ class DistillerPageIOS : public DistillerPage {
void OnLoadURLDone(web::PageLoadCompletionStatus load_completion_status);
// Called once the |script_| has been evaluated on the page.
- void HandleJavaScriptResultString(NSString* result);
+ void HandleJavaScriptResult(id result);
+
+ std::unique_ptr<base::Value> ValueResultFromWKResult(id wk_result);
Eugene But (OOO till 7-30) 2016/09/09 15:28:28 Optional NIT: Maybe s/WKResult/ScriptResult for co
Eugene But (OOO till 7-30) 2016/09/09 15:28:28 Per Style Guide every non-trivial method needs com
lody 2016/09/19 15:34:35 Done.
web::BrowserState* browser_state_;
GURL url_;
« no previous file with comments | « no previous file | components/dom_distiller/ios/distiller_page_ios.mm » ('j') | components/dom_distiller/ios/distiller_page_ios.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698