Fix domdistiller for new JS execution

ios/web/web_state/ui/web_view_js_utils_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/ui/web_view_js_utils.h"
 
 #include "base/callback_helpers.h"
 #include "base/logging.h"
 #include "base/mac/bind_objc_block.h"
 #include "base/values.h"
@@ skipping 75 matching lines @@
 
   base::DictionaryValue const* inner_dictionary = nullptr;
   dictionary->GetDictionary("Key2", &inner_dictionary);
   EXPECT_NE(nullptr, inner_dictionary);
 
   double value3;
   inner_dictionary->GetDouble("Key3", &value3);
   EXPECT_EQ(42, value3);
 }
 
+// Tests that ValueResultFromWKResult converts NSArray to properly
+// initialized base::ListValue.
+TEST(WebViewJsUtilsTest, ValueResultFromArrayWKResult) {

[Eugene But (OOO till 7-30), 2016/09/19 21:52:27]

Could you please add test for stack smashing case (deep array).

[lody, 2016/09/20 13:41:37]

Done, and test caught bug! (insert "is such a thing even possible" meme here ;)
)

+  NSArray* test_array = @[ @"Value1", @[ @YES ], @42 ];
+
+  std::unique_ptr<base::Value> value(web::ValueResultFromWKResult(test_array));
+  base::ListValue* list = nullptr;
+  value->GetAsList(&list);
+  EXPECT_NE(nullptr, list);
+
+  size_t list_size = 3;
+  EXPECT_EQ(list_size, list->GetSize());
+
+  std::string value1;
+  list->GetString(0, &value1);
+  EXPECT_EQ("Value1", value1);
+
+  base::ListValue const* inner_list;

[Eugene But (OOO till 7-30), 2016/09/19 21:52:27]

Please initialize

[lody, 2016/09/20 13:41:37]

Done.

+  list->GetList(1, &inner_list);
+  EXPECT_NE(nullptr, inner_list);
+
+  double value3;
+  list->GetDouble(2, &value3);
+  EXPECT_EQ(42, value3);
+}
+
 // Tests that an NSDictionary with a cycle does not cause infinite recursion.
 TEST(WebViewJsUtilsTest, ValueResultFromDictionaryWithDepthCheckWKResult) {
   // Create a dictionary with a cycle.
   NSMutableDictionary* test_dictionary =
       [NSMutableDictionary dictionaryWithCapacity:1];
   NSMutableDictionary* test_dictionary_2 =
       [NSMutableDictionary dictionaryWithCapacity:1];
   const char* key = "key";
   NSString* obj_c_key =
       [NSString stringWithCString:key encoding:NSASCIIStringEncoding];
@@ skipping 19 matching lines @@
        current_depth++) {
     EXPECT_NE(nullptr, current_dictionary);
     inner_dictionary = nullptr;
     current_dictionary->GetDictionary(key, &inner_dictionary);
     current_dictionary = inner_dictionary;
   }
   EXPECT_EQ(nullptr, current_dictionary);
 }
 
 }  // namespace web