Issue 232773003: Make sure to always remove temp directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232773003: Make sure to always remove temp directory. (Closed)

Created:
6 years, 8 months ago by ricow1

Modified:
6 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make sure to always remove temp directory. I don't think we get the onDone call when we get the error R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34928

Patch Set 2 : #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	tests/standalone/io/file_input_stream_test.dart	View		1 chunk	+6 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm, with comments https://codereview.chromium.org/232773003/diff/20001/tests/standalone/io/file_input_stream_test.dart File tests/standalone/io/file_input_stream_test.dart (right): https://codereview.chromium.org/232773003/diff/20001/tests/standalone/io/file_input_stream_test.dart#newcode218 tests/standalone/io/file_input_stream_test.dart:218: temp.delete(recursive: true); Use deleteSync https://codereview.chromium.org/232773003/diff/20001/tests/standalone/io/file_input_stream_test.dart#newcode223 tests/standalone/io/file_input_stream_test.dart:223: ...

6 years, 8 months ago (2014-04-10 14:27:58 UTC) #2

ricow1

6 years, 8 months ago (2014-04-10 14:33:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r34928 (presubmit successful).

Expand Messages | Collapse Messages

Issue 232773003: Make sure to always remove temp directory. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages