chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java - Issue 2327673002: Mark flaky chrome_public tests with @RetryOnFailure Batch 1

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Issue 2327673002: Mark flaky chrome_public tests with @RetryOnFailure Batch 1 (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicyTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

index 19b5518832d6535fa6a0f4f8bb7cc218c580cd4f..37e5481becf54bf861ae6c67376383b22405abcf 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

@@ -29,6 +29,7 @@ import org.chromium.base.test.util.DisabledTest;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.FlakyTest;

import org.chromium.base.test.util.Restriction;

+import org.chromium.base.test.util.RetryOnFailure;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.ChromeTabbedActivity;

@@ -960,6 +961,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testHidesWhenOmniboxFocused() throws InterruptedException, TimeoutException {

clickWordNode("intelligence");

@@ -979,6 +981,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testDoesContainAWord() {

assertTrue(mSelectionController.doesContainAWord("word"));

assertTrue(mSelectionController.doesContainAWord("word "));

@@ -998,6 +1001,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testIsValidSelection() {

StubbedContentViewCore stubbedCvc = new StubbedContentViewCore(

getActivity().getBaseContext());

@@ -1022,6 +1026,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTap() throws InterruptedException, TimeoutException {

clickWordNode("intelligence");

@@ -1038,6 +1043,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testLongPress() throws InterruptedException, TimeoutException {

longPressNode("states");

@@ -1142,6 +1148,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction({RESTRICTION_TYPE_NON_LOW_END_DEVICE})

+ @RetryOnFailure

public void testPrefetchFailoverRequestMadeAfterOpen()

throws InterruptedException, TimeoutException {

mFakeServer.reset();

@@ -1171,6 +1178,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapDisablePreload() throws InterruptedException, TimeoutException {

clickWordNode("intelligence");

@@ -1187,6 +1195,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testLongPressGestureSelects() throws InterruptedException, TimeoutException {

longPressNode("intelligence");

assertEquals("Intelligence", getSelectedText());

@@ -1207,6 +1216,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapGestureSelects() throws InterruptedException, TimeoutException {

clickWordNode("intelligence");

assertEquals("Intelligence", getSelectedText());

@@ -1225,6 +1235,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapGestureOnSpecialCharacterDoesntSelect()

throws InterruptedException, TimeoutException {

clickNode("question-mark");

@@ -1240,6 +1251,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapGestureFollowedByScrollClearsSelection()

throws InterruptedException, TimeoutException {

clickWordNode("intelligence");

@@ -1258,6 +1270,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapGestureFollowedByInvalidTextTapCloses()

throws InterruptedException, TimeoutException {

clickWordNode("states-far");

@@ -1274,6 +1287,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapGestureFollowedByNonTextTap()

throws InterruptedException, TimeoutException {

clickWordNode("states-far");

@@ -1288,6 +1302,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapGestureFarAwayTogglesSelecting()

throws InterruptedException, TimeoutException {

clickWordNode("states");

@@ -1309,6 +1324,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapGesturesNearbyKeepSelecting()

throws InterruptedException, TimeoutException {

clickWordNode("states");

@@ -1398,6 +1414,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testContextualSearchNotDismissedOnBackgroundTabCrash()

throws InterruptedException, TimeoutException {

ChromeTabUtils.newTabFromMenu(getInstrumentation(),

@@ -1494,6 +1511,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapOnARIAIgnored() throws InterruptedException, TimeoutException {

PanelState initialState = mPanel.getPanelState();

clickNode("aria");

@@ -1506,6 +1524,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapOnFocusableIgnored() throws InterruptedException, TimeoutException {

PanelState initialState = mPanel.getPanelState();

clickNode("focusable");

@@ -1519,6 +1538,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Feature({"ContextualSearch"})

@Restriction({ChromeRestriction.RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})

@DisableIf.Build(supported_abis_includes = "arm64-v8a", message = "crbug.com/596533")

+ @RetryOnFailure

public void testTapLimitForDecided() throws InterruptedException, TimeoutException {

mPolicy.setTapLimitForDecidedForTesting(2);

clickToTriggerPrefetch();

@@ -1548,6 +1568,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Feature({"ContextualSearch"})

@Restriction({ChromeRestriction.RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})

@DisableIf.Build(supported_abis_includes = "arm64-v8a", message = "crbug.com/596533")

+ @RetryOnFailure

public void testTapLimitForUndecided() throws InterruptedException, TimeoutException {

mPolicy.setTapLimitForUndecidedForTesting(2);

mPolicy.overrideDecidedStateForTesting(false);

@@ -1579,6 +1600,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction({RESTRICTION_TYPE_NON_LOW_END_DEVICE})

+ @RetryOnFailure

public void testExpandBeforeSearchTermResolution()

throws InterruptedException, TimeoutException {

clickWordNode("states");

@@ -1603,6 +1625,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction({RESTRICTION_TYPE_NON_LOW_END_DEVICE})

+ @RetryOnFailure

public void testSearchTermResolutionError() throws InterruptedException, TimeoutException {

clickWordNode("states");

assertSearchTermRequested();

@@ -1622,6 +1645,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testHttpsBeforeAcceptForOptOut() throws InterruptedException, TimeoutException {

mPolicy.overrideDecidedStateForTesting(false);

mFakeServer.setShouldUseHttps(true);

@@ -1637,6 +1661,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testHttpsAfterAcceptForOptOut() throws InterruptedException, TimeoutException {

mPolicy.overrideDecidedStateForTesting(true);

mFakeServer.setShouldUseHttps(true);

@@ -1650,6 +1675,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testHttpBeforeAcceptForOptOut() throws InterruptedException, TimeoutException {

mPolicy.overrideDecidedStateForTesting(false);

@@ -1662,6 +1688,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testHttpAfterAcceptForOptOut() throws InterruptedException, TimeoutException {

mPolicy.overrideDecidedStateForTesting(true);

@@ -1718,6 +1745,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testAppMenuSuppressedWhenMaximized() throws InterruptedException, TimeoutException {

clickWordNode("states");

flingPanelUpToTop();

@@ -1745,6 +1773,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction({RESTRICTION_TYPE_NON_LOW_END_DEVICE})

+ @RetryOnFailure

public void testPromoTapCount() throws InterruptedException, TimeoutException {

mPolicy.setPromoTapTriggeredLimitForTesting(2);

mPolicy.overrideDecidedStateForTesting(false);

@@ -1875,6 +1904,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction({ChromeRestriction.RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})

+ @RetryOnFailure

public void testNotifyObserverHideAfterLongPress()

throws InterruptedException, TimeoutException {

TestContextualSearchObserver observer = new TestContextualSearchObserver();

@@ -1921,6 +1951,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testNotifyObserverHideOnClearSelectionAfterTap()

throws InterruptedException, TimeoutException {

TestContextualSearchObserver observer = new TestContextualSearchObserver();

@@ -1951,6 +1982,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testPreventHandlingCurrentSelectionModification()

throws InterruptedException, TimeoutException {

longPressNode("intelligence");

@@ -1980,6 +2012,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

@CommandLineFlags.Add(ContextualSearchFieldTrial.SUPPRESSION_TAPS + "=" + PLENTY_OF_TAPS)

+ @RetryOnFailure

public void testTapALot() throws InterruptedException, TimeoutException {

mPolicy.setTapLimitForDecidedForTesting(PLENTY_OF_TAPS);

mPolicy.setTapLimitForUndecidedForTesting(PLENTY_OF_TAPS);

@@ -2023,6 +2056,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testRedirectedExternalNavigationWithUserGesture() {

final ExternalNavigationHandler externalNavHandler =

new ExternalNavigationHandler(getActivity().getActivityTab());

@@ -2057,6 +2091,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testExternalNavigationWithoutUserGesture() {

final ExternalNavigationHandler externalNavHandler =

new ExternalNavigationHandler(getActivity().getActivityTab());

@@ -2079,6 +2114,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testSelectionExpansionOnSearchTermResolution()

throws InterruptedException, TimeoutException {

mFakeServer.reset();

@@ -2098,6 +2134,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Restriction({ChromeRestriction.RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})

@CommandLineFlags.Add(ContextualSearchFieldTrial.PEEK_PROMO_ENABLED + "=true")

@DisableIf.Build(supported_abis_includes = "arm64-v8a", message = "crbug.com/596533")

+ @RetryOnFailure

public void testLongPressShowsPeekPromo() throws InterruptedException, TimeoutException {

// Must be in undecided state in order to trigger the Peek Promo.

mPolicy.overrideDecidedStateForTesting(false);

@@ -2138,6 +2175,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction({ChromeRestriction.RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})

+ @RetryOnFailure

public void testTapContentVisibility() throws InterruptedException, TimeoutException {

// Simulate a tap and make sure Content is not visible.

simulateTapSearch("search");

@@ -2252,6 +2290,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testChainedSearchCreatesNewContent()

throws InterruptedException, TimeoutException {

// Simulate a tap and make sure Content is not visible.

@@ -2336,6 +2375,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction({RESTRICTION_TYPE_NON_LOW_END_DEVICE})

+ @RetryOnFailure

public void testChainedSearchContentVisibility() throws InterruptedException, TimeoutException {

// Simulate a tap and make sure Content is not visible.

simulateTapSearch("search");

@@ -2370,6 +2410,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testTapCloseRemovedFromHistory()

throws InterruptedException, TimeoutException {

// Simulate a tap and make sure a URL was loaded.

@@ -2413,6 +2454,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

+ @RetryOnFailure

public void testChainedTapsRemovedFromHistory()

throws InterruptedException, TimeoutException {

// Simulate a tap and make sure a URL was loaded.

@@ -2455,6 +2497,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

@CommandLineFlags.Add(ContextualSearchFieldTrial.ENABLE_TRANSLATION + "=true")

+ @RetryOnFailure

public void testTapWithLanguage() throws InterruptedException, TimeoutException {

// Tapping a German word should trigger translation.

simulateTapSearch("german");

@@ -2489,6 +2532,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

@CommandLineFlags.Add({ContextualSearchFieldTrial.ENABLE_TRANSLATION + "=true",

ContextualSearchFieldTrial.ENABLE_SERVER_CONTROLLED_ONEBOX + "=true"})

+ @RetryOnFailure

public void testTapWithoutLanguageCanBeForced() throws InterruptedException, TimeoutException {

// Tapping an English word should trigger translation.

simulateTapSearch("search");

@@ -2504,6 +2548,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Feature({"ContextualSearch"})

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

@CommandLineFlags.Add(ContextualSearchFieldTrial.ENABLE_TRANSLATION + "=true")

+ @RetryOnFailure

public void testLongpressTranslates() throws InterruptedException, TimeoutException {

// LongPress on any word should trigger translation.

simulateLongPressSearch("search");

@@ -2520,6 +2565,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

@CommandLineFlags.Add({ContextualSearchFieldTrial.ENABLE_TRANSLATION + "=true",

ContextualSearchFieldTrial.DISABLE_AUTO_DETECT_TRANSLATION_ONEBOX + "=true"})

+ @RetryOnFailure

public void testLongpressAutoDetectDisabledDoesNotTranslate()

throws InterruptedException, TimeoutException {

// Unless disabled, LongPress on any word should trigger translation.

@@ -2537,6 +2583,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)

@CommandLineFlags.Add({ContextualSearchFieldTrial.ENABLE_TRANSLATION + "=true",

ContextualSearchFieldTrial.DISABLE_FORCE_TRANSLATION_ONEBOX + "=true"})

+ @RetryOnFailure

public void testLongpressTranslateDisabledDoesNotTranslate()

throws InterruptedException, TimeoutException {

// Unless disabled, LongPress on any word should trigger translation.

@@ -2578,6 +2625,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

@SmallTest

@Feature({"ContextualSearch"})

@Restriction({RESTRICTION_TYPE_NON_LOW_END_DEVICE})

+ @RetryOnFailure

public void testPanelDismissedOnToggleFullscreen()

throws InterruptedException, TimeoutException {

// Simulate a tap and assert that the panel peeks.