third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ASSERT_UNUSED Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/LinkLoader.cpp ('K') | « third_party/WebKit/Source/core/loader/LinkLoader.cpp ('k') | third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h » ('j') | third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp b/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

index 4a8fc5e64866e830b3a2e98917f8067dcd08d726..2e35d76e5ecd3bd52861c26dcd334973e26d95c3 100644

--- a/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

+++ b/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

@@ -150,7 +150,7 @@ TEST(LinkLoaderTest, Preload)

hrefURL,

dummyPageHolder->document(),

NetworkHintsMock());

- ASSERT(dummyPageHolder->document().fetcher());

+ DCHECK(dummyPageHolder->document().fetcher());

HeapListHashSet<Member<Resource>>* preloads = dummyPageHolder->document().fetcher()->preloads();

if (testCase.expectingLoad) {

if (!preloads)