third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ASSERT_UNUSED Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/FrameLoader.cpp ('K') | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/core/loader/HistoryItem.cpp » ('j') | third_party/WebKit/Source/core/loader/HttpEquiv.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp b/third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp

index b5d7a9d326369a52689ce5a6a09e601e67560d54..441965c1e3f95a50b4187028a8eaca0cedf92592 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp

@@ -61,7 +61,7 @@ bool FrameLoaderStateMachine::isDisplayingInitialEmptyDocument() const

void FrameLoaderStateMachine::advanceTo(State state)

{

- ASSERT(m_state < state);

+ DCHECK(m_state < state);

yhirano 2016/09/12 04:33:13 DCHECK_LT

hiroshige 2016/09/13 08:43:20 Done.

m_state = state;

}

@@ -77,7 +77,7 @@ String FrameLoaderStateMachine::toString() const

case CommittedMultipleRealLoads:

return "CommittedMultipleRealLoads";

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

return "";

}