third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ASSERT_UNUSED Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/MemoryCache.cpp » ('j') | third_party/WebKit/Source/core/fetch/MemoryCache.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp b/third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp

index 02d01ed41877041e7a48087076a45174150654d8..1c5164e16cfa5085738862a3687d62d7deee3b7f 100644

--- a/third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp

@@ -12,8 +12,8 @@ namespace blink {

Resource* LinkFetchResource::fetch(Resource::Type type, FetchRequest& request, ResourceFetcher* fetcher)

{

- ASSERT(type == LinkPrefetch);

- ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);

+ DCHECK(type == LinkPrefetch);

yhirano 2016/09/12 04:33:11 DCHECK_EQ

hiroshige 2016/09/13 08:43:18 Done.

+ DCHECK(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);

yhirano 2016/09/12 04:33:11 ditto

hiroshige 2016/09/13 08:43:18 Done.

fetcher->determineRequestContext(request.mutableResourceRequest(), type);

return fetcher->requestResource(request, LinkResourceFactory(type));

}