third_party/WebKit/Source/core/loader/ProgressTracker.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/ProgressTracker.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace many DCHECK(a && b) with DCHECK(a) and DCHECK(b) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentWriter.cpp ('K') | « third_party/WebKit/Source/core/loader/PingLoader.cpp ('k') | third_party/WebKit/Source/core/loader/TextTrackLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/ProgressTracker.cpp

diff --git a/third_party/WebKit/Source/core/loader/ProgressTracker.cpp b/third_party/WebKit/Source/core/loader/ProgressTracker.cpp

index 03bfef631c31253a24d8bbb2bc4557d65184c183..4aff408e1003ae0cd336f7b1bf4b801f8d39a871 100644

--- a/third_party/WebKit/Source/core/loader/ProgressTracker.cpp

+++ b/third_party/WebKit/Source/core/loader/ProgressTracker.cpp

@@ -90,7 +90,7 @@ void ProgressTracker::dispose()

{

if (m_frame->isLoading())

progressCompleted();

- ASSERT(!m_frame->isLoading());

+ DCHECK(!m_frame->isLoading());

}

double ProgressTracker::estimatedProgress() const

@@ -119,7 +119,7 @@ void ProgressTracker::progressStarted()

void ProgressTracker::progressCompleted()

{

- ASSERT(m_frame->isLoading());

+ DCHECK(m_frame->isLoading());

m_frame->setIsLoading(false);

sendFinalProgress();

reset();

@@ -211,7 +211,7 @@ void ProgressTracker::maybeSendProgress()

DCHECK_GE(m_progressValue, initialProgressValue);

// Always leave space at the end. This helps show the user that we're not

// done until we're done.

- DCHECK(m_progressValue <= 0.9);

+ DCHECK_LE(m_progressValue, 0.9);

if (m_progressValue < m_lastNotifiedProgressValue)

return;