third_party/WebKit/Source/core/loader/HttpEquiv.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/HttpEquiv.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace many DCHECK(a && b) with DCHECK(a) and DCHECK(b) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentWriter.cpp ('K') | « third_party/WebKit/Source/core/loader/HistoryItem.cpp ('k') | third_party/WebKit/Source/core/loader/ImageLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/HttpEquiv.cpp

diff --git a/third_party/WebKit/Source/core/loader/HttpEquiv.cpp b/third_party/WebKit/Source/core/loader/HttpEquiv.cpp

index 083f1126735ed6cc8c394f1c2369997476808c48..9e4cd719cbc269e888d30109e7ef078598a94eed 100644

--- a/third_party/WebKit/Source/core/loader/HttpEquiv.cpp

+++ b/third_party/WebKit/Source/core/loader/HttpEquiv.cpp

@@ -21,7 +21,8 @@ namespace blink {

void HttpEquiv::process(Document& document, const AtomicString& equiv, const AtomicString& content, bool inDocumentHeadElement)

{

- ASSERT(!equiv.isNull() && !content.isNull());

+ DCHECK(!equiv.isNull());

+ DCHECK(!content.isNull());

if (equalIgnoringCase(equiv, "default-style")) {

processHttpEquivDefaultStyle(document, content);

@@ -59,7 +60,7 @@ void HttpEquiv::processHttpEquivContentSecurityPolicy(Document& document, const

else if (equalIgnoringCase(equiv, "content-security-policy-report-only"))

document.contentSecurityPolicy()->didReceiveHeader(content, ContentSecurityPolicyHeaderTypeReport, ContentSecurityPolicyHeaderSourceMeta);

else

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

void HttpEquiv::processHttpEquivAcceptCH(Document& document, const AtomicString& content)