third_party/WebKit/Source/core/fetch/FetchRequest.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/FetchRequest.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace many DCHECK(a && b) with DCHECK(a) and DCHECK(b) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp ('K') | « third_party/WebKit/Source/core/fetch/DocumentResource.cpp ('k') | third_party/WebKit/Source/core/fetch/FontResource.cpp » ('j') | third_party/WebKit/Source/core/loader/DocumentWriter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/FetchRequest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/FetchRequest.cpp b/third_party/WebKit/Source/core/fetch/FetchRequest.cpp

index c589971a58d9e0ffaa617270ca16e3b42532f126..a2dbbd927b60693ea50d3205e1fa5dbe0fb571a8 100644

--- a/third_party/WebKit/Source/core/fetch/FetchRequest.cpp

+++ b/third_party/WebKit/Source/core/fetch/FetchRequest.cpp

@@ -73,7 +73,7 @@ FetchRequest::~FetchRequest()

void FetchRequest::setCrossOriginAccessControl(SecurityOrigin* origin, CrossOriginAttributeValue crossOrigin)

{

- ASSERT(crossOrigin != CrossOriginAttributeNotSet);

+ DCHECK_NE(crossOrigin, CrossOriginAttributeNotSet);

const bool useCredentials = crossOrigin == CrossOriginAttributeUseCredentials;

const bool isSameOriginRequest = origin && origin->canRequestNoSuborigin(m_resourceRequest.url());