Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 232753002: Password bubble: Deplatformify ManagePasswordsBubbleView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index f42cd9c8ed2289b2cd1baaefbe57e6cdb67aee46..3ae22d42d1d936d4953b8929de5525652c885bc5 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -22,7 +22,15 @@ enum ResponseType {
NUM_RESPONSE_TYPES,
};
-// Metrics: "PasswordManager.UIResponse"
+// Metrics: "PasswordBubble.DisplayDisposition"
+enum UIDisplayDisposition {
+ AUTOMATIC_WITH_PASSWORD_PENDING = 0,
+ MANUAL_WITH_PASSWORD_PENDING,
+ MANUAL_MANAGE_PASSWORDS,
+ NUM_DISPLAY_DISPOSITIONS
+};
+
+// Metrics: "PasswordManager.UIDismissalReason"
enum UIDismissalReason {
// We use this to mean both "Bubble lost focus" and "No interaction with the
// infobar", depending on which experiment is active.
@@ -82,6 +90,9 @@ void LogUIDismissalReason(UIDismissalReason reason);
// has rolled out to stable.
void LogUIDismissalReason(ResponseType type);
+// Log the appropriate display disposition.
+void LogUIDisplayDisposition(UIDisplayDisposition disposition);
+
} // namespace metrics_util
} // namespace password_manager
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | components/password_manager/core/browser/password_manager_metrics_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698