chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc - Issue 232753002: Password bubble: Deplatformify ManagePasswordsBubbleView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

Issue 232753002: Password bubble: Deplatformify ManagePasswordsBubbleView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Feedback. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

index 668678464caedbeb000d32f4c4485171cf34e0d7..e0d433c0b882d3f4bc6cb9bede7a60b43b875ffb 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

@@ -28,8 +28,7 @@ void ManagePasswordsIconView::Update(

manage_passwords_icon_to_be_shown() &&

!location_bar_delegate_->GetToolbarModel()->input_in_progress());

if (!visible()) {

- ManagePasswordsBubbleView::CloseBubble(

- password_manager::metrics_util::NOT_DISPLAYED);

+ ManagePasswordsBubbleView::CloseBubble();

return;

}

int icon_to_display =