Password bubble: Deplatformify ManagePasswordsBubbleView.

components/password_manager/core/browser/password_manager_metrics_util.h

Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index f42cd9c8ed2289b2cd1baaefbe57e6cdb67aee46..28d5cc6293bd8bbf3bd52ff74fe019911851f414 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -22,6 +22,14 @@ enum ResponseType {
   NUM_RESPONSE_TYPES,
 };
 
+// Metrics: "PasswordBubble.DisplayDisposition"

[vabr (Chromium), 2014/04/10 10:24:44]

Higher up in the CL, you talk about values of this type as "reasons". I'm not
sure I understand the word "disposition" properly, although it's one of those
cosmopolitans, which also happens to be a Czech word (and I'm sure has different
meaning from [define disposition]).

If you are introducing the name here, could you reconsider it?
If it already is used somewhere in this context, then it's fine to leave it.

+enum UIDisplayDisposition {
+  AUTOMATIC_WITH_PASSWORD_PENDING = 0,
+  MANUAL_WITH_PASSWORD_PENDING,
+  MANUAL_MANAGE_PASSWORDS,
+  NUM_DISPLAY_DISPOSITIONS
+};
+
 // Metrics: "PasswordManager.UIResponse"
 enum UIDismissalReason {
   // We use this to mean both "Bubble lost focus" and "No interaction with the
@@ -82,6 +90,9 @@ void LogUIDismissalReason(UIDismissalReason reason);
 // has rolled out to stable.
 void LogUIDismissalReason(ResponseType type);
 
+// Log the appropriate display disposition.
+void LogUIDisplayDisposition(UIDisplayDisposition disposition);
+
 }  // namespace metrics_util
 
 }  // namespace password_manager