chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm - Issue 2327433002: Stop using CertStore which is not compatible with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

Issue 2327433002: Stop using CertStore which is not compatible with PlzNavigate. (Closed)

Patch Set: remove cert_store on ios Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm ('k') | chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

index b1f6caf1554c7a4f65a22e4b2fcc6140d734e0f2..04a95d5a5d3899e98b08ae70f9e294b74fcdc4b7 100644

--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

@@ -10,6 +10,7 @@

#include "base/macros.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"

+#include "net/test/test_certificate_data.h"

#include "testing/gtest_mac.h"

@interface WebsiteSettingsBubbleController (ExposedForTesting)

@@ -260,7 +261,8 @@ TEST_F(WebsiteSettingsBubbleControllerTest, ResetDecisionsButton) {

EXPECT_EQ([controller_ resetDecisionsButton], nil);

// Set identity info, specifying that the button should be shown.

- info.cert_id = 1;

+ info.certificate = net::X509Certificate::CreateFromBytes(

+ reinterpret_cast<const char*>(google_der), sizeof(google_der));

info.show_ssl_decision_revoke_button = true;

bridge_->SetIdentityInfo(const_cast<WebsiteSettingsUI::IdentityInfo&>(info));

EXPECT_NE([controller_ resetDecisionsButton], nil);