Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2327433002: Stop using CertStore which is not compatible with PlzNavigate. (Closed)
Patch Set: remove cert_store on ios Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/certificate_viewer.cc ('k') | chrome/browser/devtools/devtools_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index d9c35831aeca3ced3713e497dbaa221c2dcb7992..1df89329bebd245c968e9e3461b9265db6b1545e 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -41,7 +41,6 @@
#include "components/prefs/scoped_user_pref_update.h"
#include "components/syncable_prefs/pref_service_syncable.h"
#include "components/zoom/page_zoom.h"
-#include "content/public/browser/cert_store.h"
#include "content/public/browser/devtools_external_agent_proxy.h"
#include "content/public/browser/devtools_external_agent_proxy_delegate.h"
#include "content/public/browser/navigation_controller.h"
@@ -717,17 +716,11 @@ void DevToolsUIBindings::ShowCertificateViewer(const std::string& cert_chain) {
return;
}
- // TODO(jam): temporarily add the certificate to the cert store to get an ID
- // so that we don't have to change the WCD method signature
- // (will be done in followups).
if (!agent_host_ || !agent_host_->GetWebContents())
return;
content::WebContents* inspected_wc = agent_host_->GetWebContents();
- content::RenderProcessHost* rph = inspected_wc->GetRenderProcessHost();
- int cert_id = content::CertStore::GetInstance()->StoreCert(
- cert.get(), rph->GetID());
web_contents_->GetDelegate()->ShowCertificateViewerInDevTools(
- inspected_wc, cert_id);
+ inspected_wc, cert.get());
}
void DevToolsUIBindings::ZoomIn() {
« no previous file with comments | « chrome/browser/certificate_viewer.cc ('k') | chrome/browser/devtools/devtools_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698