Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2327433002: Stop using CertStore which is not compatible with PlzNavigate. (Closed)
Patch Set: remove certstore on non-ios and update plznavigate test filter Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index a16eaa07595e04b68d825ea6896fa7528da0acf7..a6bbc2b97327749f977fd039be9b4ad7996680be 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -226,13 +226,10 @@ WebInspector.SecurityPanel.prototype = {
return this._filterRequestCounts.get(filterKey) || 0;
},
- /**
- * @param {!SecurityAgent.CertificateId} certificateId
- */
- showCertificateViewer: function(certificateId)
+ showCertificateViewer: function()
{
var securityModel = WebInspector.SecurityModel.fromTarget(this._target);
- securityModel.showCertificateViewer(certificateId);
+ securityModel.showCertificateViewer();
},
/**
@@ -330,11 +327,10 @@ WebInspector.SecurityPanel._instance = function()
/**
* @param {string} text
- * @param {!SecurityAgent.CertificateId} certificateId
* @param {!WebInspector.SecurityPanel} panel
* @return {!Element}
*/
-WebInspector.SecurityPanel.createCertificateViewerButton = function(text, certificateId, panel)
+WebInspector.SecurityPanel.createCertificateViewerButton = function(text, panel)
{
/**
* @param {!Event} e
@@ -342,7 +338,7 @@ WebInspector.SecurityPanel.createCertificateViewerButton = function(text, certif
function showCertificateViewer(e)
{
e.consume();
- panel.showCertificateViewer(certificateId);
+ panel.showCertificateViewer();
}
return createTextButton(text, showCertificateViewer, "security-certificate-button");
@@ -631,8 +627,8 @@ WebInspector.SecurityMainView.prototype = {
text.createChild("div", "security-explanation-title").textContent = explanation.summary;
text.createChild("div").textContent = explanation.description;
- if (explanation.certificateId) {
- text.appendChild(WebInspector.SecurityPanel.createCertificateViewerButton(WebInspector.UIString("View certificate"), explanation.certificateId, this._panel));
+ if (explanation.hasCertificate) {
+ text.appendChild(WebInspector.SecurityPanel.createCertificateViewerButton(WebInspector.UIString("View certificate"), this._panel));
}
return text;

Powered by Google App Engine
This is Rietveld 408576698