ios/chrome/browser/ssl/ios_ssl_blocking_page.mm - Issue 2327433002: Stop using CertStore which is not compatible with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ssl/ios_ssl_blocking_page.mm

Issue 2327433002: Stop using CertStore which is not compatible with PlzNavigate. (Closed)

Patch Set: remove certstore on non-ios and update plznavigate test filter Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ssl/ios_ssl_blocking_page.mm

diff --git a/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm b/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm

index b689c5981214d619321340a39d5d9d1b1cd6d43d..097632b528d99f3e49d240a81e11c9f48d74ce0f 100644

--- a/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm

+++ b/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm

@@ -195,8 +195,7 @@ void IOSSSLBlockingPage::OverrideItem(web::NavigationItem* item) {

// On iOS cert may be null when it is not provided by API callback or can not

// be parsed.

if (ssl_info_.cert) {

- item->GetSSL().cert_id = web::CertStore::GetInstance()->StoreCert(

- ssl_info_.cert.get(), web_state()->GetCertGroupId());

+ item->GetSSL().certificate = ssl_info_.cert;

}