Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2327353002: Fix official Windows build. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
dmurph
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix official Windows build. Fix visibility when using split static libraries. NOTRY=true BUG=645621 TBR=dmurph Committed: https://crrev.com/668425a36f0df11b34d55753fe7d4750d47f7ab9 Cr-Commit-Position: refs/heads/master@{#417819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/bindings/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327353002/1
4 years, 3 months ago (2016-09-10 02:38:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327353002/1
4 years, 3 months ago (2016-09-10 04:13:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-10 04:16:24 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 04:18:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/668425a36f0df11b34d55753fe7d4750d47f7ab9
Cr-Commit-Position: refs/heads/master@{#417819}

Powered by Google App Engine
This is Rietveld 408576698