Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2327273002: [DevTools] Added more null check into DispatcherBase template (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Added more null check into DispatcherBase template R=dgozman@chromium.org Committed: https://crrev.com/9ff4610e4b671ac11b79e3d0ad9e4ef934da5a71 Cr-Commit-Position: refs/heads/master@{#417848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/lib/DispatcherBase_cpp.template View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kozy
Dmitry, please take a look!
4 years, 3 months ago (2016-09-09 22:24:39 UTC) #1
dgozman
lgtm
4 years, 3 months ago (2016-09-09 22:57:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327273002/1
4 years, 3 months ago (2016-09-09 23:32:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/294068)
4 years, 3 months ago (2016-09-10 01:56:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327273002/1
4 years, 3 months ago (2016-09-10 22:04:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-10 23:08:13 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 23:10:16 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ff4610e4b671ac11b79e3d0ad9e4ef934da5a71
Cr-Commit-Position: refs/heads/master@{#417848}

Powered by Google App Engine
This is Rietveld 408576698