|
|
Chromium Code Reviews
DescriptionUse a scroll recorder rather than scroll offset for composited-scrolling backgrounds.
BUG=643741
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852
Cr-Commit-Position: refs/heads/master@{#417843}
Patch Set 1 #
Total comments: 1
Patch Set 2 : none #Messages
Total messages: 19 (14 generated)
Description was changed from ========== none BUG= ========== to ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Description was changed from ========== Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. BUG=643741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
chrishtr@chromium.org changed reviewers: + flackr@chromium.org
https://codereview.chromium.org/2327243002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/paint/BoxPainter.cpp (right): https://codereview.chromium.org/2327243002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/paint/BoxPainter.cpp:62: Optional<ScrollRecorder> scrollRecorder; *ScrollDisplayItems are never cached, so the caching problem is avoided.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. We could add a test but my upcoming patch will test this anyways on the existing tests so perhaps it's not important to add a test here.
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. BUG=643741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. BUG=643741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852 Cr-Commit-Position: refs/heads/master@{#417843} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852 Cr-Commit-Position: refs/heads/master@{#417843} |
