Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2327243002: Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. (Closed)

Created:
4 years, 3 months ago by chrishtr
Modified:
4 years, 3 months ago
Reviewers:
flackr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. BUG=643741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852 Cr-Commit-Position: refs/heads/master@{#417843}

Patch Set 1 #

Total comments: 1

Patch Set 2 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
chrishtr
https://codereview.chromium.org/2327243002/diff/1/third_party/WebKit/Source/core/paint/BoxPainter.cpp File third_party/WebKit/Source/core/paint/BoxPainter.cpp (right): https://codereview.chromium.org/2327243002/diff/1/third_party/WebKit/Source/core/paint/BoxPainter.cpp#newcode62 third_party/WebKit/Source/core/paint/BoxPainter.cpp:62: Optional<ScrollRecorder> scrollRecorder; *ScrollDisplayItems are never cached, so the caching ...
4 years, 3 months ago (2016-09-09 21:46:46 UTC) #7
flackr
LGTM. We could add a test but my upcoming patch will test this anyways on ...
4 years, 3 months ago (2016-09-10 11:31:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327243002/20001
4 years, 3 months ago (2016-09-10 20:43:20 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-10 20:46:53 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 20:49:35 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852
Cr-Commit-Position: refs/heads/master@{#417843}

Powered by Google App Engine
This is Rietveld 408576698