Fix module verifier test by padding out DummyExport with 256 bytes of nops

Fix module verifier test by padding out DummyExport with 256 bytes of nops

The test increments 256 bytes of code starting from the beginning
of the DLL, and if we don't pad out DummyExport, it will modify DllMain,
which can run when a thread starts.

R=grt@chromium.org,thakis@chromium.org
BUG=645544
Committed: https://crrev.com/38eb7adb1ff6ab5d5151fd47bf251e12da7db0e2
Cr-Commit-Position: refs/heads/master@{#417944}

[Nico, 2016-09-09 20:56:29]

lgtm, thanks!

https://codereview.chromium.org/2327193002/diff/1/chrome/browser/safe_browsin...
File
chrome/browser/safe_browsing/incident_reporting/verifier_test/verifier_test_dll.cc
(right):

https://codereview.chromium.org/2327193002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/verifier_test/verifier_test_dll.cc:25:
__nop();
Hm, maybe

#define T4(x) x; x; x; x
#define NOP4 T4(__nop());
#define NOP16 T4(NOP4);
#define NOP64 T4(NOP16);
#define NOP256 T4(NOP64);
NOP256;

? (untested)

[grt (UTC plus 2), 2016-09-11 09:43:12]

rubberstamp lgtm. thanks for making this work!

[Nico, 2016-09-12 14:24:54]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-09-12 14:25:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reid Kleckner, 2016-09-12 14:47:52]

The CQ bit was unchecked by rnk@chromium.org

[Reid Kleckner, 2016-09-12 14:48:54]

use macros

[Reid Kleckner, 2016-09-12 14:48:59]

The CQ bit was checked by rnk@chromium.org

[Reid Kleckner, 2016-09-12 14:48:59]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
grt@chromium.org
Link to the patchset: https://codereview.chromium.org/2327193002/#ps20001
(title: "use macros")

[commit-bot: I haz the power, 2016-09-12 14:49:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 15:28:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-12 15:30:36]

Description was changed from

==========
Fix module verifier test by padding out DummyExport with 256 bytes of nops

The test increments 256 bytes of code starting from the beginning
of the DLL, and if we don't pad out DummyExport, it will modify DllMain,
which can run when a thread starts.

R=grt@chromium.org,thakis@chromium.org
BUG=645544
==========

to

==========
Fix module verifier test by padding out DummyExport with 256 bytes of nops

The test increments 256 bytes of code starting from the beginning
of the DLL, and if we don't pad out DummyExport, it will modify DllMain,
which can run when a thread starts.

R=grt@chromium.org,thakis@chromium.org
BUG=645544

Committed: https://crrev.com/38eb7adb1ff6ab5d5151fd47bf251e12da7db0e2
Cr-Commit-Position: refs/heads/master@{#417944}
==========

[commit-bot: I haz the power, 2016-09-12 15:30:37]

Patchset 2 (id:??) landed as
https://crrev.com/38eb7adb1ff6ab5d5151fd47bf251e12da7db0e2
Cr-Commit-Position: refs/heads/master@{#417944}