Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2327103004: Mojo Java Bindings: expose public API for struct serialization. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo Java Bindings: expose public API for struct serialization. This CL adds methods to serialize to / deserialize from ByteBuffer. BUG=643447 Committed: https://crrev.com/df7fe83f8d3cabac81ebef3d809c11adafe5014d Cr-Commit-Position: refs/heads/master@{#417838}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/SerializationTest.java View 1 2 2 chunks +44 lines, -0 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Struct.java View 1 2 chunks +19 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
yzshen1
Hi, Ken. Please take a look. Thanks!
4 years, 3 months ago (2016-09-09 23:00:32 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-09 23:06:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327103004/20001
4 years, 3 months ago (2016-09-09 23:06:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/126955)
4 years, 3 months ago (2016-09-10 00:20:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327103004/40001
4 years, 3 months ago (2016-09-10 15:26:51 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-10 16:42:28 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 16:43:55 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/df7fe83f8d3cabac81ebef3d809c11adafe5014d
Cr-Commit-Position: refs/heads/master@{#417838}

Powered by Google App Engine
This is Rietveld 408576698