[stubs] Port KeyedLoadSloppyArgumentsStub and KeyedStoreSloppyArgumentsStub to TurboFan.

[stubs] Port KeyedLoadSloppyArgumentsStub and KeyedStoreSloppyArgumentsStub to TurboFan.

BUG=v8:5269
Committed: https://crrev.com/b9b350cb124ddb8a78e0963b7864442eca8f13f0
Cr-Commit-Position: refs/heads/master@{#39372}

[Igor Sheludko, 2016-09-09 18:46:19]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-09-09 18:59:43]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-09-09 19:01:09]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 19:01:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 19:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 19:13:17]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Igor Sheludko, 2016-09-09 19:24:44]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 19:24:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 19:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 19:37:28]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Igor Sheludko, 2016-09-09 20:11:00]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 20:11:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-09-09 20:34:31]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-09-09 20:34:38]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-09-09 20:36:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 20:36:22]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-09-12 08:33:04]

ishell@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Igor Sheludko, 2016-09-12 08:33:04]

PTAL

[Igor Sheludko, 2016-09-12 15:04:32]

Description was changed from

==========
[stubs] Port KeyedLoadSloppyArgumentsStub and KeyedStoreSloppyArgumentsStub to
TurboFan.

BUG=v8:5269
==========

to

==========
[stubs] Port KeyedLoadSloppyArgumentsStub and KeyedStoreSloppyArgumentsStub to
TurboFan.

BUG=v8:5269
==========

[Igor Sheludko, 2016-09-12 15:58:48]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 15:58:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 16:24:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 16:24:37]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2016-09-13 07:23:05]

lgtm, one comment that may be worth following up on.

https://codereview.chromium.org/2327103002/diff/80001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2327103002/diff/80001/src/code-stub-assembler...
src/code-stub-assembler.cc:4343: Node* value, Label* bailout) {
I recognize it's a "straight port" but it would be cool to avoid this thing
where null value makes the difference between store and load. Maybe expose
EmitLoadKeyedSloppyArguments() and EmitStoreKeyedSloppyArguments() instead.

[Igor Sheludko, 2016-09-13 07:43:24]

https://codereview.chromium.org/2327103002/diff/80001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2327103002/diff/80001/src/code-stub-assembler...
src/code-stub-assembler.cc:4343: Node* value, Label* bailout) {
On 2016/09/13 07:23:05, mvstanton wrote:
> I recognize it's a "straight port" but it would be cool to avoid this thing
> where null value makes the difference between store and load. Maybe expose
> EmitLoadKeyedSloppyArguments() and EmitStoreKeyedSloppyArguments() instead.

Done.

[Igor Sheludko, 2016-09-13 07:43:29]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 07:43:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 08:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 08:08:17]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-09-13 08:22:18]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-09-13 08:22:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2327103002/#ps100001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-09-13 08:22:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 08:24:51]

Description was changed from

==========
[stubs] Port KeyedLoadSloppyArgumentsStub and KeyedStoreSloppyArgumentsStub to
TurboFan.

BUG=v8:5269
==========

to

==========
[stubs] Port KeyedLoadSloppyArgumentsStub and KeyedStoreSloppyArgumentsStub to
TurboFan.

BUG=v8:5269
==========

[commit-bot: I haz the power, 2016-09-13 08:24:52]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-09-13 08:25:03]

Description was changed from

==========
[stubs] Port KeyedLoadSloppyArgumentsStub and KeyedStoreSloppyArgumentsStub to
TurboFan.

BUG=v8:5269
==========

to

==========
[stubs] Port KeyedLoadSloppyArgumentsStub and KeyedStoreSloppyArgumentsStub to
TurboFan.

BUG=v8:5269

Committed: https://crrev.com/b9b350cb124ddb8a78e0963b7864442eca8f13f0
Cr-Commit-Position: refs/heads/master@{#39372}
==========

[commit-bot: I haz the power, 2016-09-13 08:25:04]

Patchset 2 (id:??) landed as
https://crrev.com/b9b350cb124ddb8a78e0963b7864442eca8f13f0
Cr-Commit-Position: refs/heads/master@{#39372}