Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3394)

Unified Diff: build/android/gyp/write_build_config.py

Issue 2327063002: Revert of Make secondary abi work for component build (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/BUILD.gn ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/write_build_config.py
diff --git a/build/android/gyp/write_build_config.py b/build/android/gyp/write_build_config.py
index d121f7d8e01b556f924ca02fc04da7a199edb3f0..1843c7481b0086503f351fba3d1f58142a2fbb17 100755
--- a/build/android/gyp/write_build_config.py
+++ b/build/android/gyp/write_build_config.py
@@ -209,11 +209,6 @@
ret.reverse()
return ret
-def _CreateJavaLibrariesList(library_paths):
- """ Create a java literal array with the "base" library names:
- e.g. libfoo.so -> foo
- """
- return ('{%s}' % ','.join(['"%s"' % s[3:-3] for s in library_paths]))
def main(argv):
parser = optparse.OptionParser()
@@ -269,9 +264,6 @@
parser.add_option('--shared-libraries-runtime-deps',
help='Path to file containing runtime deps for shared '
'libraries.')
- parser.add_option('--secondary-abi-shared-libraries-runtime-deps',
- help='Path to file containing runtime deps for secondary '
- 'abi shared libraries.')
# apk options
parser.add_option('--apk-path', help='Path to the target\'s apk output.')
@@ -637,24 +629,15 @@
options.shared_libraries_runtime_deps or '[]')
if runtime_deps_files:
library_paths = _ExtractSharedLibsFromRuntimeDeps(runtime_deps_files)
- java_libraries_list = _CreateJavaLibrariesList(library_paths)
-
- secondary_abi_library_paths = []
- secondary_abi_java_libraries_list = None
- secondary_abi_runtime_deps_files = build_utils.ParseGnList(
- options.secondary_abi_shared_libraries_runtime_deps or '[]')
- if secondary_abi_runtime_deps_files:
- secondary_abi_library_paths = _ExtractSharedLibsFromRuntimeDeps(
- secondary_abi_runtime_deps_files)
- secondary_abi_java_libraries_list = _CreateJavaLibrariesList(
- secondary_abi_library_paths)
+ # Create a java literal array with the "base" library names:
+ # e.g. libfoo.so -> foo
+ java_libraries_list = ('{%s}' % ','.join(
+ ['"%s"' % s[3:-3] for s in library_paths]))
all_inputs.extend(runtime_deps_files)
config['native'] = {
'libraries': library_paths,
- 'secondary_abi_libraries': secondary_abi_library_paths,
'java_libraries_list': java_libraries_list,
- 'secondary_abi_java_libraries_list': secondary_abi_java_libraries_list,
}
config['assets'], config['uncompressed_assets'] = (
_MergeAssets(deps.All('android_assets')))
« no previous file with comments | « build/android/BUILD.gn ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698