Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: build/config/android/internal_rules.gni

Issue 2327063002: Revert of Make secondary abi work for component build (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/write_build_config.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index a5d63aae4d3796ebe9cf16dacd879c44343977b8..14554cb4d1b7a2f02263320f1dcd0b0bba62a1b9 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -5,7 +5,6 @@
import("//build_overrides/build.gni")
import("//build/config/android/config.gni")
import("//build/config/sanitizers/sanitizers.gni")
-import("//third_party/android_platform/config.gni")
assert(is_android)
@@ -301,17 +300,6 @@
]
}
- if (defined(invoker.secondary_abi_shared_libraries_runtime_deps_file)) {
- # Don't list secondary_abi_shared_libraries_runtime_deps_file as an
- # input in order to avoid having to depend on the runtime_deps target.
- # See comment in rules.gni for why we do this.
- args += [
- "--secondary-abi-shared-libraries-runtime-deps",
- rebase_path(invoker.secondary_abi_shared_libraries_runtime_deps_file,
- root_build_dir),
- ]
- }
-
if (defined(invoker.proguard_enabled) && invoker.proguard_enabled) {
args += [
"--proguard-enabled",
@@ -1284,16 +1272,8 @@
if (_native_lib_placeholders != []) {
args += [ "--native-lib-placeholders=$_native_lib_placeholders" ]
}
-
- # TODO (michaelbai): Remove the secondary_native_libs variable.
- if (defined(invoker.secondary_abi_native_libs_filearg)) {
- assert(defined(android_app_secondary_abi))
- args += [
- "--secondary-native-libs=${invoker.secondary_abi_native_libs_filearg}",
- "--secondary-android-abi=$android_app_secondary_abi",
- ]
- } else if (defined(invoker.secondary_native_libs) &&
- invoker.secondary_native_libs != []) {
+ if (defined(invoker.secondary_native_libs) &&
+ invoker.secondary_native_libs != []) {
assert(defined(android_app_secondary_abi))
inputs += invoker.secondary_native_libs
_secondary_native_libs = rebase_path(invoker.secondary_native_libs)
@@ -1618,7 +1598,6 @@
"emma_instrument",
"native_lib_placeholders",
"native_libs_filearg",
- "secondary_abi_native_libs_filearg",
"secondary_native_libs",
"uncompress_shared_libraries",
"write_asset_list",
@@ -2662,39 +2641,3 @@
}
}
}
-
-template("pack_relocation_section") {
- assert(defined(invoker.file_list_json))
- assert(defined(invoker.libraries_filearg))
- action(target_name) {
- forward_variables_from(invoker,
- [
- "deps",
- "public_deps",
- "inputs",
- "testonly",
- ])
- script = "//build/android/gyp/pack_relocations.py"
- depfile = "$target_gen_dir/$target_name.d"
- _packed_libraries_dir = "$target_gen_dir/$target_name/packed-libs"
- outputs = [
- invoker.file_list_json,
- ]
- deps += [ relocation_packer_target ]
-
- args = [
- "--depfile",
- rebase_path(depfile, root_build_dir),
- "--enable-packing=1",
- "--android-pack-relocations",
- rebase_path(relocation_packer_exe, root_build_dir),
- "--stripped-libraries-dir",
- rebase_path(root_build_dir, root_build_dir),
- "--packed-libraries-dir",
- rebase_path(_packed_libraries_dir, root_build_dir),
- "--libraries=${invoker.libraries_filearg}",
- "--filelistjson",
- rebase_path(invoker.file_list_json, root_build_dir),
- ]
- }
-}
« no previous file with comments | « build/android/gyp/write_build_config.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698