Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2327063002: Revert of Make secondary abi work for component build (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make secondary abi work for component build (patchset #5 id:80001 of https://codereview.chromium.org/2319273002/ ) Reason for revert: Broke v8 roller Original issue's description: > Make secondary abi work for component build > > Add secondary_abi_shared_libraries to pack all the secondary abi > shared libraries into APK. > > BUG=622855 > > Committed: https://crrev.com/3ac692c2e67e8030a30e4ebcd12240352944f898 > Cr-Commit-Position: refs/heads/master@{#417441} TBR=machenbach@chromium.org,michaelbai@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622855 Committed: https://crrev.com/43c48e4e358edc63ab8f032d2e94f59c177776c7 Cr-Commit-Position: refs/heads/master@{#417580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -169 lines) Patch
M build/android/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M build/android/gyp/write_build_config.py View 3 chunks +4 lines, -21 lines 0 comments Download
M build/config/android/internal_rules.gni View 5 chunks +2 lines, -59 lines 0 comments Download
M build/config/android/rules.gni View 7 chunks +33 lines, -85 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
agrieve
Created Revert of Make secondary abi work for component build
4 years, 3 months ago (2016-09-09 14:20:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327063002/1
4 years, 3 months ago (2016-09-09 14:20:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 14:21:43 UTC) #4
Michael Achenbach
lgtm - thanks!
4 years, 3 months ago (2016-09-09 14:22:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/43c48e4e358edc63ab8f032d2e94f59c177776c7 Cr-Commit-Position: refs/heads/master@{#417580}
4 years, 3 months ago (2016-09-09 14:23:34 UTC) #7
agrieve
4 years, 3 months ago (2016-09-09 14:30:18 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2326973003/ by agrieve@chromium.org.

The reason for reverting is: will update when fixed.

Powered by Google App Engine
This is Rietveld 408576698