Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2327033002: [gn] Switch off gyp in runhooks by default (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Committed: https://crrev.com/9a3b720395416cf33f0d1c001ae4eeadad01b0a3 Cr-Original-Commit-Position: refs/heads/master@{#39308} Cr-Commit-Position: refs/heads/master@{#39311}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix a typo #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gypfiles/gyp_v8 View 1 2 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 31 (19 generated)
Michael Achenbach
PTAL A PSA is out: https://groups.google.com/forum/#!topic/v8-dev/f5PMQT2BDe8 Our deprecated gyp documentation doesn't rely on gyp in ...
4 years, 3 months ago (2016-09-09 13:13:48 UTC) #8
Michael Achenbach
https://codereview.chromium.org/2327033002/diff/1/gypfiles/gyp_v8 File gypfiles/gyp_v8 (right): https://codereview.chromium.org/2327033002/diff/1/gypfiles/gyp_v8#newcode130 gypfiles/gyp_v8:130: print '`python build/gyp_v8` explicitly by hand ' hmm - ...
4 years, 3 months ago (2016-09-09 13:15:49 UTC) #9
Michael Achenbach
Typo fix in patch 2
4 years, 3 months ago (2016-09-09 13:18:35 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-09 13:26:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327033002/20001
4 years, 3 months ago (2016-09-09 13:31:20 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 13:33:02 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Cr-Commit-Position: refs/heads/master@{#39308}
4 years, 3 months ago (2016-09-09 13:33:35 UTC) #21
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2324173002/ by machenbach@chromium.org. ...
4 years, 3 months ago (2016-09-09 14:09:09 UTC) #22
Michael Achenbach
Patch 3 is another fix. Porting: https://cs.chromium.org/chromium/src/build/gyp_chromium.py?q=%22--running-as-hook%22+file:%5Esrc/&sq=package:chromium&dr=C&l=340
4 years, 3 months ago (2016-09-09 14:19:30 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327033002/40001
4 years, 3 months ago (2016-09-09 14:20:22 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-09 14:22:24 UTC) #29
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 14:23:25 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9a3b720395416cf33f0d1c001ae4eeadad01b0a3
Cr-Commit-Position: refs/heads/master@{#39311}

Powered by Google App Engine
This is Rietveld 408576698