|
|
Created:
4 years, 3 months ago by Michael Achenbach Modified:
4 years, 3 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Switch off gyp in runhooks by default
This will be synced with an announcement on v8-dev. This
doesn't affect directly calling gyp in our old Makefiles.
BUG=chromium:474921
NOTRY=true
Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501
Committed: https://crrev.com/9a3b720395416cf33f0d1c001ae4eeadad01b0a3
Cr-Original-Commit-Position: refs/heads/master@{#39308}
Cr-Commit-Position: refs/heads/master@{#39311}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix a typo #Patch Set 3 : Fix #Messages
Total messages: 31 (19 generated)
Description was changed from ========== [gn] Switch off gyp in runhooks by default BUG= ========== to ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. BUG=chromium:474921 ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. BUG=chromium:474921 ========== to ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
machenbach@chromium.org changed reviewers: + jkummerow@chromium.org, jochen@chromium.org, vogelheim@chromium.org
PTAL A PSA is out: https://groups.google.com/forum/#!topic/v8-dev/f5PMQT2BDe8 Our deprecated gyp documentation doesn't rely on gyp in runhooks anyways - gyp_v8 is called explicitly, so it will continue to work after this. Same with Makefiles. Infrastructure preparation landed: https://codereview.chromium.org/2320853005/
https://codereview.chromium.org/2327033002/diff/1/gypfiles/gyp_v8 File gypfiles/gyp_v8 (right): https://codereview.chromium.org/2327033002/diff/1/gypfiles/gyp_v8#newcode130 gypfiles/gyp_v8:130: print '`python build/gyp_v8` explicitly by hand ' hmm - typo - will fix
Typo fix in patch 2
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 ========== to ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true ========== to ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true ========== to ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Cr-Commit-Position: refs/heads/master@{#39308} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Cr-Commit-Position: refs/heads/master@{#39308}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2324173002/ by machenbach@chromium.org. The reason for reverting is: Broke stuff - need to fix the argument.
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Cr-Commit-Position: refs/heads/master@{#39308} ========== to ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Cr-Commit-Position: refs/heads/master@{#39308} ==========
Patch 3 is another fix. Porting: https://cs.chromium.org/chromium/src/build/gyp_chromium.py?q=%22--running-as-...
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2327033002/#ps40001 (title: "Fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Cr-Commit-Position: refs/heads/master@{#39308} ========== to ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Cr-Commit-Position: refs/heads/master@{#39308} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Cr-Commit-Position: refs/heads/master@{#39308} ========== to ========== [gn] Switch off gyp in runhooks by default This will be synced with an announcement on v8-dev. This doesn't affect directly calling gyp in our old Makefiles. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 Committed: https://crrev.com/9a3b720395416cf33f0d1c001ae4eeadad01b0a3 Cr-Original-Commit-Position: refs/heads/master@{#39308} Cr-Commit-Position: refs/heads/master@{#39311} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/9a3b720395416cf33f0d1c001ae4eeadad01b0a3 Cr-Commit-Position: refs/heads/master@{#39311} |