Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 232703004: gn docs generator: Don't get confused by ansi escape codes. (Closed)

Created:
6 years, 8 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

gn docs generator: Don't get confused by ansi escape codes. BUG=362239 TEST=links at the top of the output actually work. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/gn/bin/help_as_html.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 8 months ago (2014-04-10 20:08:24 UTC) #1
scottmg
I was mentally thinking that if this script had to include re it had gone ...
6 years, 8 months ago (2014-04-10 20:53:48 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-10 20:54:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/232703004/1
6 years, 8 months ago (2014-04-10 20:55:27 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 21:17:32 UTC) #5
Message was sent while issue was closed.
Change committed as 263087

Powered by Google App Engine
This is Rietveld 408576698