Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2327023002: Removed ios plist generation and ios_plist writer (Closed)

Created:
4 years, 3 months ago by ljusten (tachyonic)
Modified:
4 years, 1 month ago
Reviewers:
flackr, bartfab (slow)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove iOS plist generation and ios_plist writer Policy support for iOS has been removed in Chrome 48, see https://www.chromium.org/administrators/ios-mdm-policy-format. This CL removes remaining code. BUG=550407 Committed: https://crrev.com/e4ce16906482e746e7d2f6759b40090284e335d5 Cr-Commit-Position: refs/heads/master@{#432857}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -372 lines) Patch
M components/policy/resources/policy_templates.grd View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/grit/grit/format/policy_templates/writers/ios_plist_writer.py View 1 chunk +0 lines, -125 lines 0 comments Download
D tools/grit/grit/format/policy_templates/writers/ios_plist_writer_unittest.py View 1 chunk +0 lines, -240 lines 0 comments Download
M tools/grit/grit/test_suite_all.py View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/grit/grit/tool/build.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
ljusten (tachyonic)
bartfab@chromium.org: Please review changes in policy_templates.grd thakis@chromium.org: Please review changes in tools/grit/grit
4 years, 3 months ago (2016-09-09 08:51:04 UTC) #2
ljusten (tachyonic)
Friendly ping. I'd like to get this landed soon as other CLs might interfere with ...
4 years, 1 month ago (2016-11-03 09:34:42 UTC) #8
bartfab (slow)
lgtm
4 years, 1 month ago (2016-11-03 11:07:14 UTC) #9
ljusten (tachyonic)
flackr@chromium.org: Please review changes in tools/grit/grit
4 years, 1 month ago (2016-11-09 09:10:58 UTC) #12
flackr
lgtm
4 years, 1 month ago (2016-11-16 21:04:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327023002/20001
4 years, 1 month ago (2016-11-17 12:17:21 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 13:42:27 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 13:44:55 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4ce16906482e746e7d2f6759b40090284e335d5
Cr-Commit-Position: refs/heads/master@{#432857}

Powered by Google App Engine
This is Rietveld 408576698