Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Issue 2326973003: Reland of Make secondary abi work for component build (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make secondary abi work for component build Reverted in: https://codereview.chromium.org/2327063002/ Reason for reland: Now guards non-build import behind enable_java_templates TBR=michaelbai,machenbach BUG=622855 Committed: https://crrev.com/2ded0b9b26d3cfdd3068b36c28d157c87cb8ab39 Cr-Commit-Position: refs/heads/master@{#417597}

Patch Set 1 #

Patch Set 2 : guard import behind enable_java_templates #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -43 lines) Patch
M build/android/BUILD.gn View 1 2 chunks +4 lines, -4 lines 0 comments Download
M build/android/gyp/write_build_config.py View 1 3 chunks +21 lines, -4 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 6 chunks +60 lines, -2 lines 2 comments Download
M build/config/android/rules.gni View 1 8 chunks +84 lines, -33 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
agrieve
Created Reland of Make secondary abi work for component build
4 years, 3 months ago (2016-09-09 14:30:18 UTC) #1
Michael Achenbach
enable_java_templates is off for v8, so this would work for us.
4 years, 3 months ago (2016-09-09 14:39:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326973003/110001
4 years, 3 months ago (2016-09-09 15:06:23 UTC) #6
agrieve
On 2016/09/09 14:39:49, machenbach (slow) wrote: > enable_java_templates is off for v8, so this would ...
4 years, 3 months ago (2016-09-09 15:07:04 UTC) #7
michaelbai
Thanks for doing this.
4 years, 3 months ago (2016-09-09 15:36:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:110001)
4 years, 3 months ago (2016-09-09 16:10:05 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2ded0b9b26d3cfdd3068b36c28d157c87cb8ab39 Cr-Commit-Position: refs/heads/master@{#417597}
4 years, 3 months ago (2016-09-09 16:12:06 UTC) #12
Michael Achenbach
not lgtm - unless I missed the point, there's an unconditional import in this CL, ...
4 years, 3 months ago (2016-09-12 06:37:02 UTC) #13
Michael Achenbach
A revert of this CL (patchset #2 id:110001) has been created in https://codereview.chromium.org/2333593002/ by machenbach@chromium.org. ...
4 years, 3 months ago (2016-09-12 07:30:36 UTC) #14
agrieve
4 years, 3 months ago (2016-09-12 14:00:47 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2326973003/diff/110001/build/config/android/i...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2326973003/diff/110001/build/config/android/i...
build/config/android/internal_rules.gni:8:
import("//third_party/android_platform/config.gni")
On 2016/09/12 06:37:02, machenbach (slow) wrote:
> So why import it here unconditionally when it's imported in line 644 behind a
> condition?

aah! Sorry :(

Powered by Google App Engine
This is Rietveld 408576698