Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2326943003: Reuse expensive string in js_rti (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M sdk/lib/_internal/js_runtime/lib/js_rti.dart View 2 chunks +16 lines, -18 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
sra1
4 years, 3 months ago (2016-09-10 00:39:28 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2326943003/diff/20001/sdk/lib/_internal/js_runtime/lib/js_rti.dart File sdk/lib/_internal/js_runtime/lib/js_rti.dart (right): https://codereview.chromium.org/2326943003/diff/20001/sdk/lib/_internal/js_runtime/lib/js_rti.dart#newcode235 sdk/lib/_internal/js_runtime/lib/js_rti.dart:235: if (substitution == null) return substitution; nit, feel ...
4 years, 3 months ago (2016-09-10 00:50:40 UTC) #4
sra1
4 years, 3 months ago (2016-09-13 00:22:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
8495283e25192402b86489aa96977cf352324ff5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698