ui/views/widget/widget_aura_utils.h - Issue 2326933002: MacViews: Fix gn check fail for mac_views_browser on Aura dependencies.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/widget/widget_aura_utils.h

Issue 2326933002: MacViews: Fix gn check fail for mac_views_browser on Aura dependencies. (Closed)

Patch Set: Typo. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_VIEWS_WIDGET_WIDGET_AURA_UTILS_H_	5 #ifndef UI_VIEWS_WIDGET_WIDGET_AURA_UTILS_H_

6 #define UI_VIEWS_WIDGET_WIDGET_AURA_UTILS_H_	6 #define UI_VIEWS_WIDGET_WIDGET_AURA_UTILS_H_

7	7

8 #include "ui/views/widget/widget.h"	8 #include "ui/views/widget/widget.h"

9 #include "ui/wm/public/window_types.h"	9 #include "ui/wm/public/window_types.h" // nogncheck
	tapted 2016/09/19 03:23:36 yeah - this one doesn't feel right, since it's not yeah - this one doesn't feel right, since it's not inside an #ifdef guard. I think the right fix for this is just to change bridged_native_widget.mm's PositionWindowInScreenCoordinates() to switch based on Widget::InitParams::Type so that it returns `true` for {FRAMELESS, POPUP, BUBBLE, DRAG}. The other types should still be listed in the switch statement rather than having a default: case - this helps mitigate the potential for the implementations to drift apart.
10	10

11 // Functions shared by native_widget_aura.cc and desktop_native_widget_aura.cc:	11 // Functions shared by native_widget_aura.cc and desktop_native_widget_aura.cc:

12	12

13 namespace views {	13 namespace views {

14	14

15 ui::wm::WindowType GetAuraWindowTypeForWidgetType(	15 ui::wm::WindowType GetAuraWindowTypeForWidgetType(

16 Widget::InitParams::Type type);	16 Widget::InitParams::Type type);

17	17

18 } // namespace views	18 } // namespace views

19	19

20 #endif // UI_VIEWS_WIDGET_WIDGET_AURA_UTILS_H_	20 #endif // UI_VIEWS_WIDGET_WIDGET_AURA_UTILS_H_

OLD	NEW

« ui/views/views_test_suite.cc ('K') | « ui/views/views_test_suite.cc ('k') | ui/views/widget/widget_unittest.cc » ('j') | ui/views/widget/widget_unittest.cc » ('J')