MacViews: Fix gn check fail for mac_views_browser on Aura dependencies.

ui/views/views_test_suite.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/views_test_suite.h"
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "base/test/launcher/unit_test_launcher.h"
 #include "base/test/test_suite.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/ui_base_paths.h"
 #include "ui/gl/test/gl_surface_test_support.h"
 
 #if defined(USE_AURA)
 #include <memory>

[tapted, 2016/09/19 03:23:36]

this is in the views_test_suite.h header, so redundant here

 
-#include "ui/aura/env.h"
+#include "ui/aura/env.h"  // nogncheck
 #endif
 
 namespace views {
 
 ViewsTestSuite::ViewsTestSuite(int argc, char** argv)
     : base::TestSuite(argc, argv), argc_(argc), argv_(argv) {}
 
 ViewsTestSuite::~ViewsTestSuite() {}
 
 int ViewsTestSuite::RunTests() {
   return base::LaunchUnitTests(
       argc_, argv_, base::Bind(&ViewsTestSuite::Run, base::Unretained(this)));
 }
 
 int ViewsTestSuite::RunTestsSerially() {
   return base::LaunchUnitTestsSerially(
       argc_, argv_, base::Bind(&ViewsTestSuite::Run, base::Unretained(this)));
 }
 
 void ViewsTestSuite::Initialize() {
   base::TestSuite::Initialize();
   gl::GLSurfaceTestSupport::InitializeOneOff();
   ui::RegisterPathProvider();
 
   base::FilePath ui_test_pak_path;
   ASSERT_TRUE(PathService::Get(ui::UI_TEST_PAK, &ui_test_pak_path));
   ui::ResourceBundle::InitSharedInstanceWithPakPath(ui_test_pak_path);
 #if defined(USE_AURA)
   env_ = aura::Env::CreateInstance();

[tapted, 2016/09/19 03:23:36]

Things using ViewsTestSuite probably also use ViewsTestHelper or AuraTestHelper,
both of which also use a unique_ptr<aura::Env>, but in a way that encapsulates
its use to aura-only files. It would be interesting to see if anything actually
relies on this... if it's only a couple of things, maybe they can be updated.
But if lots breaks, this should be kept. (an alternative could be to declare
something like

// views_test_suite.h
class ViewsTestSuite::PlatformPart {
 public:
  virtual ~PlatformPart() {}
  static unique_ptr<PlatformPart> Create();
 protected:
  PlatformPart() {} 
};

#if !defined(USE_AURA)
unique_ptr<ViewsTestSuite::PlatformPart> ViewsTestSuite::PlatformPart::Create()
{
  return MakeUnique(new PlatformPart);
}
#endif

views_test_suite_aura.cc
namespace {
class PlatformPartAura : public ViewsTestSuite::PlatformPart {
 / *etc */
};
}

unique_ptr<ViewsTestSuite::PlatformPart> ViewsTestSuite::PlatformPart::Create()
{
  return MakeUnique(new PlatformPartAura);
}



I think here, this would be a bit of overkill and // nogncheck is fine. However,
a similar pattern applied to the other cases could be an improvement to code
health.

 #endif
 }
 
 void ViewsTestSuite::Shutdown() {
 #if defined(USE_AURA)
   env_.reset();
 #endif
   ui::ResourceBundle::CleanupSharedInstance();
   base::TestSuite::Shutdown();
 }
 
 }  // namespace views