Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: net/tools/cert_verify_tool/verify_using_path_builder.cc

Issue 2326923002: Introduce CertErrors::ToDebugString(). (Closed)
Patch Set: checkpoint Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/data/verify_certificate_chain_unittest/common.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/cert_verify_tool/verify_using_path_builder.cc
diff --git a/net/tools/cert_verify_tool/verify_using_path_builder.cc b/net/tools/cert_verify_tool/verify_using_path_builder.cc
index 4c66a0e8e5338a70ba19fa63d22e7c7e6bc858a1..54ed618a5e3c9ac0f88860d90786458879dc92c5 100644
--- a/net/tools/cert_verify_tool/verify_using_path_builder.cc
+++ b/net/tools/cert_verify_tool/verify_using_path_builder.cc
@@ -119,15 +119,6 @@ std::string SubjectFromTrustAnchor(const net::TrustAnchor* trust_anchor) {
return SubjectToString(parsed_subject);
}
-void PrintCertErrors(const net::CertErrors& errors) {
- // TODO(crbug.com/634443): Include more detailed error information. Also this
- // should likely be extracted to a common location and used by unit-tests and
- // other debugging needs.
- for (const auto& error : errors.errors()) {
- std::cout << " " << error.type << "\n";
- }
-}
-
// Dumps a ResultPath to std::cout.
void PrintResultPath(const net::CertPathBuilder::ResultPath* result_path,
size_t index,
@@ -157,7 +148,7 @@ void PrintResultPath(const net::CertPathBuilder::ResultPath* result_path,
// Print the errors.
if (!result_path->errors.errors().empty()) {
std::cout << "Errors:\n";
- PrintCertErrors(result_path->errors);
+ std::cout << result_path->errors.ToDebugString() << "\n";
}
}
« no previous file with comments | « net/data/verify_certificate_chain_unittest/common.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698