Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2326923002: Introduce CertErrors::ToDebugString(). (Closed)

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce CertErrors::ToDebugString(). This removes some duplicated code. BUG=634443 Committed: https://crrev.com/00dba514371aaeae740c069266263a9544044b3d Cr-Commit-Position: refs/heads/master@{#417498}

Patch Set 1 #

Patch Set 2 : checkpoint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -30 lines) Patch
M net/cert/internal/cert_errors.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/cert/internal/cert_errors.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_unittest.cc View 2 chunks +1 line, -17 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/README View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/common.py View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/cert_verify_tool/verify_using_path_builder.cc View 1 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
eroman
4 years, 3 months ago (2016-09-09 01:00:05 UTC) #6
mattm
lgtm
4 years, 3 months ago (2016-09-09 01:20:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326923002/20001
4 years, 3 months ago (2016-09-09 03:57:34 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 04:05:29 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00dba514371aaeae740c069266263a9544044b3d
Cr-Commit-Position: refs/heads/master@{#417498}

Powered by Google App Engine
This is Rietveld 408576698