Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2326913004: Adding UMA stats for Blimp Client (Closed)

Created:
4 years, 3 months ago by shaktisahu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, asvitkine+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding UMA stats for Blimp Client Added metrics for tracking when blimp is supported, blimp is connected, blimp tabs are shown or hidden, size of commit messages. BUG=645545 Committed: https://crrev.com/f769f364f71068930d971dafb86dc1c5f298a8a7 Cr-Commit-Position: refs/heads/master@{#418386}

Patch Set 1 #

Total comments: 2

Patch Set 2 : dtrainor comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M blimp/client/core/blimp_client_context_impl.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M blimp/client/core/dummy_blimp_client_context.cc View 2 chunks +4 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
shaktisahu
4 years, 3 months ago (2016-09-09 20:20:58 UTC) #3
shaktisahu
PTAL
4 years, 3 months ago (2016-09-12 17:50:21 UTC) #5
David Trainor- moved to gerrit
lgtm but make sure we understand the implications of the tab visibility UMA. Let's talk ...
4 years, 3 months ago (2016-09-13 05:46:16 UTC) #6
shaktisahu
rkaplow@ : PTAL https://codereview.chromium.org/2326913004/diff/1/blimp/client/core/compositor/blimp_compositor.cc File blimp/client/core/compositor/blimp_compositor.cc (right): https://codereview.chromium.org/2326913004/diff/1/blimp/client/core/compositor/blimp_compositor.cc#newcode138 blimp/client/core/compositor/blimp_compositor.cc:138: message->ByteSize()); On 2016/09/13 05:46:16, David Trainor ...
4 years, 3 months ago (2016-09-13 17:28:20 UTC) #8
rkaplow
lgtm
4 years, 3 months ago (2016-09-13 19:53:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326913004/20001
4 years, 3 months ago (2016-09-13 20:30:22 UTC) #14
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 3 months ago (2016-09-13 22:04:07 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 22:05:07 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f769f364f71068930d971dafb86dc1c5f298a8a7
Cr-Commit-Position: refs/heads/master@{#418386}

Powered by Google App Engine
This is Rietveld 408576698